Feature/gometalinter (#71)

* non contentious changes

* minor code changes, should be zero impact

examples/juniper/get_system_information.go

@@ -30,6 +30,7 @@ var (
 	agent        = flag.Bool("agent", false, "Use SSH agent for public key authentication")
 )
 
+// SystemInformation provides a representation of the system-information container
 type SystemInformation struct {
 	HardwareModel string `xml:"system-information>hardware-model"`
 	OsName        string `xml:"system-information>os-name"`
@@ -38,10 +39,11 @@ type SystemInformation struct {
 	HostName      string `xml:"system-information>host-name"`
 }
 
+// BuildConfig captures information from the console to build a SSH Client Config
 func BuildConfig() *ssh.ClientConfig {
 	var config *ssh.ClientConfig
 	var pass string
-	if *pubkey == true {
+	if *pubkey {
 		if *agent {
 			var err error
 			config, err = netconf.SSHConfigPubKeyAgent(*username)
@@ -58,7 +60,7 @@ func BuildConfig() *ssh.ClientConfig {
 					var readpass []byte
 					var err error
 					fmt.Printf("Enter Passphrase for %s: ", *key)
-					readpass, err = terminal.ReadPassword(int(syscall.Stdin))
+					readpass, err = terminal.ReadPassword(syscall.Stdin)
 					if err != nil {
 						log.Fatal(err)
 					}
@@ -74,7 +76,7 @@ func BuildConfig() *ssh.ClientConfig {
 		}
 	} else {
 		fmt.Printf("Enter Password: ")
-		bytePassword, err := terminal.ReadPassword(int(syscall.Stdin))
+		bytePassword, err := terminal.ReadPassword(syscall.Stdin)
 		if err != nil {
 			log.Fatal(err)
 		}
@@ -109,7 +111,10 @@ func main() {
 	}
 	var q SystemInformation
 
-	xml.Unmarshal([]byte(reply.RawReply), &q)
+	err = xml.Unmarshal([]byte(reply.RawReply), &q)
+	if err != nil {
+		log.Fatal(err)
+	}
 	fmt.Printf("hostname: %s\n", q.HostName)
 	fmt.Printf("model: %s\n", q.HardwareModel)
 	fmt.Printf("version: %s\n", q.OsVersion)

netconf/rpc_test.go

@@ -146,7 +146,7 @@ func TestUUIDChar(t *testing.T) {
 	u := uuid()
 
 	for _, v := range u {
-		if valid(int(v)) == false {
+		if !valid(int(v)) {
 			t.Errorf("invalid char %s", string(v))
 
 		}

netconf/session.go

@@ -5,7 +5,7 @@
 // license that can be found in the LICENSE file.
 
 /*
-This library is a simple NETCONF client based on RFC6241 and RFC6242
+Package netconf provides support for a a simple NETCONF client based on RFC6241 and RFC6242
 (although not fully compliant yet).
 */
 package netconf

netconf/transport.go

@@ -43,7 +43,6 @@ type Transport interface {
 
 type transportBasicIO struct {
 	io.ReadWriteCloser
-	chunkedFraming bool
 }
 
 // Sends a well formated NETCONF rpc message as a slice of bytes adding on the
@@ -83,7 +82,7 @@ func (t *transportBasicIO) ReceiveHello() (*HelloMessage, error) {
 		return hello, err
 	}
 
-	err = xml.Unmarshal([]byte(val), hello)
+	err = xml.Unmarshal(val, hello)
 	return hello, err
 }
 

netconf/transport_ssh.go

@@ -71,11 +71,7 @@ func (t *TransportSSH) Dial(target string, config *ssh.ClientConfig) error {
 	}
 
 	err = t.setupSession()
-	if err != nil {
-		return err
-	}
-
-	return nil
+	return err
 }
 
 func (t *TransportSSH) setupSession() error {
@@ -177,8 +173,7 @@ func SSHConfigPubKeyFile(user string, file string, passphrase string) (*ssh.Clie
 	}
 
 	if x509.IsEncryptedPEMBlock(block) {
-		b := block.Bytes
-		b, err = x509.DecryptPEMBlock(block, []byte(passphrase))
+		b, err := x509.DecryptPEMBlock(block, []byte(passphrase))
 		if err != nil {
 			return nil, err
 		}