Merge pull request #1159 from balasankarrajaguru/fix_lxml_version

Fix lxml version
Juniper · Feb 28, 2022 · 048f750 · 048f750
2 parents d3c065a + 167d319
commit 048f750
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/jnpr/junos/factory/table.py b/lib/jnpr/junos/factory/table.py
@@ -245,7 +245,9 @@ def savexml(self, path, hostname=False, timestamp=False, append=None):
             fname += "_%s" % append
 
         path = fname + fext
-        return etree.ElementTree(self.xml).write(open(path, "wb"))
+        with open(path, "wb+") as f:
+            pass
+        return etree.ElementTree(self.xml).write(path)
 
     def to_json(self):
         """

diff --git a/tests/unit/factory/test_table.py b/tests/unit/factory/test_table.py
@@ -139,9 +139,9 @@ def test_table_get_RuntimeError(self):
     def test_table_savexml(self, mock_file, mock_execute):
         mock_execute.side_effect = self._mock_manager
         self.ppt.xml = etree.XML("<root><a>test</a></root>")
-        self.ppt.savexml("/vasr/tmssp/foo.xml", hostname=True, append="test")
-        mock_file.assert_called_once_with("/vasr/tmssp/foo_1.1.1.1_test.xml", "wb")
-        self.ppt.savexml("/vasr/tmssp/foo.xml", hostname=True, timestamp=True)
+        self.ppt.savexml("foo.xml", hostname=True, append="test")
+        mock_file.assert_called_once_with("foo_1.1.1.1_test.xml", "wb+")
+        self.ppt.savexml("foo.xml", hostname=True, timestamp=True)
         self.assertEqual(mock_file.call_count, 2)
 
     def _read_file(self, fname):