Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win serial COM support #1000

Merged
merged 7 commits into from
Mar 31, 2020
Merged

Win serial COM support #1000

merged 7 commits into from
Mar 31, 2020

Conversation

vnitinv
Copy link
Contributor

@vnitinv vnitinv commented Mar 17, 2020

Fix #943

@coveralls
Copy link

coveralls commented Mar 18, 2020

Coverage Status

Coverage increased (+0.1%) to 94.997% when pulling b0db8fb on vnitinv:win-serial-com into 962f454 on Juniper:master.

@vnitinv
Copy link
Contributor Author

vnitinv commented Mar 23, 2020

Log from successful execution

INFO:jnpr.junos.tty:TTY: connecting to TTY:COM4 ...
INFO:jnpr.junos.tty:TTY: logging in......
INFO:jnpr.junos.tty:TTY: OK.....starting NETCONF
DEBUG:jnpr.junos.tty_netconf:Received: 
b'<!-- user root, class super-user --><hello xmlns="urn:ietf:params:xml:ns:netconf:base:1.0"><capabilities><capability>urn:ietf:params:netconf:base:1.0</capability><capability>urn:ietf:params:netconf:capability:candidate:1.0</capability><capability>urn:ietf:params:netconf:capability:confirmed-commit:1.0</capability><capability>urn:ietf:params:netconf:capability:validate:1.0</capability><capability>urn:ietf:params:netconf:capability:url:1.0?scheme=http,ftp,file</capability><capability>urn:ietf:params:xml:ns:netconf:base:1.0</capability><capability>urn:ietf:params:xml:ns:netconf:capability:candidate:1.0</capability><capability>urn:ietf:params:xml:ns:netconf:capability:confirmed-commit:1.0</capability><capability>urn:ietf:params:xml:ns:netconf:capability:validate:1.0</capability><capability>urn:ietf:params:xml:ns:netconf:capability:url:1.0?protocol=http,ftp,file</capability><capability>http://xml.juniper.net/netconf/junos/1.0</capability><capability>http://xml.juniper.net/dmi/system/1.0</capability></capabilities><session-id>4653</session-id></hello>'
INFO:jnpr.junos.tty_netconf:Calling rpc: b'<rpc><load-configuration format="text" action="set"><configuration-set>set system host-name test4</configuration-set></load-configuration></rpc>'
DEBUG:jnpr.junos.tty_netconf:Received: 
b'<rpc-reply xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" xmlns:junos="http://xml.juniper.net/junos/15.1X49/junos"><load-configuration-results><ok/></load-configuration-results></rpc-reply>'
INFO:jnpr.junos.tty_netconf:Calling rpc: b'<rpc><commit-configuration/></rpc>'
DEBUG:jnpr.junos.tty_netconf:Received: 
b'<rpc-reply xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" xmlns:junos="http://xml.juniper.net/junos/15.1X49/junos"><ok/></rpc-reply>'
INFO:jnpr.junos.tty:logout: logging out.....
INFO:jnpr.junos.tty_netconf:Calling rpc: b'<rpc><close-session/></rpc>'
DEBUG:jnpr.junos.tty_netconf:Received: 
b'<rpc-reply xmlns="urn:ietf:params:xml:ns:netconf:base:1.0" xmlns:junos="http://xml.juniper.net/junos/15.1X49/junos"><ok/></rpc-reply>'

@vnitinv
Copy link
Contributor Author

vnitinv commented Mar 23, 2020

ok to test

Copy link
Collaborator

@dineshbaburam91 dineshbaburam91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vnitinv vnitinv merged commit 500939b into Juniper:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IO Exception Over Serial On Windows
3 participants