textfsm window version check #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if sys.version_info[:2] == (2, 6): | ||
| install_reqs.append('importlib>=1.0.3') | ||
| if sys.platform == 'win32': | ||
| install_reqs.append('textfsm==0.4.1') |
There was a problem hiding this comment.
Why did we remove importlib ?
Kindly add the comment saying win32 supports testfsm 0.4.1.
There was a problem hiding this comment.
We dont support python 2.6 and importlib was explicitly needed for that version.
>=2.7 python got importlib by default
p-sherratt
added a commit
to p-sherratt/py-junos-eznc
that referenced
this pull request
May 29, 2020
Juniper#1019 no longer addresses issue of textfsm import in windows because of a change in ntc-templates==1.4.2 : ImportError: cannot import name 'clitable' from 'textfsm' (<redacted>\lib\site-packages\textfsm\__init__.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now only around 800 test cases get executed for windows and others are skipped. will fix skipped one in future.