Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textfsm to be manually installed by the user #1085

Merged
merged 3 commits into from Oct 27, 2020

Conversation

rahkumar651991
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 94.323% when pulling abe39cd on rahkumar651991:crpd_check into 58a3fea on Juniper:master.

@coveralls
Copy link

coveralls commented Oct 14, 2020

Coverage Status

Coverage decreased (-0.07%) to 94.32% when pulling 2b54d33 on rahkumar651991:crpd_check into 58a3fea on Juniper:master.

@ntwrkguru
Copy link
Contributor

So, was this optional before? I never understood the requirement for ntc_templates. If textfsm is needed, I think it can be installed without ntc_templates. What was the use case for its inclusion originally, @rahkumar651991?

@vnitinv
Copy link
Contributor

vnitinv commented Oct 15, 2020

@ntwrkguru we need ntc_templates. Had to add textfsm (0.4.1) very specifically for windows due to some bug.
These modules are very limited in use and were added mainly for healthbot use case. But this is causing the issue of upgrading PyEZ on-box Junos due different vendor contents. So we are making this module's installation optional and to be done only if some want to use PyEZ table/view with other vendors cli o/p contents.

@ntwrkguru
Copy link
Contributor

@ntwrkguru we need ntc_templates. Had to add textfsm (0.4.1) very specifically for windows due to some bug.
These modules are very limited in use and were added mainly for healthbot use case. But this is causing the issue of upgrading PyEZ on-box Junos due different vendor contents. So we are making this module's installation optional and to be done only if some want to use PyEZ table/view with other vendors cli o/p contents.

Thanks for the clarification @vnitinv I think this is the right decision. Healthbot should not push additional external libs to PyEZ, rather use PyEZ as the base image from which to built their use case. This is pattern and makes sense to me.

Copy link
Contributor

@vnitinv vnitinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vnitinv vnitinv merged commit 2ebf076 into Juniper:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants