Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevented AttributeError upon XML comment. Fixes #446 #447

Closed
wants to merge 4 commits into from
Closed

Prevented AttributeError upon XML comment. Fixes #446 #447

wants to merge 4 commits into from

Conversation

jeffbrl
Copy link
Contributor

@jeffbrl jeffbrl commented Oct 20, 2015

The remove_namespace function in jxml.py would previously raise an Attribute error if it encountered an XML comment. This change adds a check for a comment before doing the tag.find.

@vnitinv
Copy link
Contributor

vnitinv commented Oct 20, 2015

@jeffbrl Can you please add unit test too so that code changes becomes rock solid.

@jeffbrl jeffbrl closed this Oct 20, 2015
@jeffbrl jeffbrl deleted the issue-446-fix branch October 20, 2015 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffbrl @vnitinv