Issu sw install #632
Issu sw install #632
Conversation
1 similar comment
| ss.run('cli', '> ', timeout=5) | ||
| data = ss.run('show system switchover', '> ', timeout=5) | ||
| output = data[1] | ||
| ss.run('exit') |
There was a problem hiding this comment.
Does this cleanly exit the request routing-engine login in all cases (both shell user and cli user)?
There was a problem hiding this comment.
Yes, as we are using context manager, StartShell creates a new connection and at the end the connection is closed. Hence no issues. If we put more ss.run('exit'), we need to be much more careful. closing connection clears all. If you suggest, we can change it as per your review.
| :returns: | ||
| * ``True`` if validation passes. | ||
| * * ``False`` otherwise | ||
| """ | ||
| self.log('Checking GRES status') |
There was a problem hiding this comment.
Suggest changing to: self.log('Checking GRES configuration')
| if conf.find('system/commit/synchronize') is None: | ||
| self.log('Requirement FAILED: commit synchronize is not Enabled in configuration') | ||
| return False | ||
| self.log('Checking NSR status') |
There was a problem hiding this comment.
Suggest changing to: self.log('Checking NSR configuration')
| 'commit-scripts': 'apply'}) | ||
| if conf.find('routing-options/nonstop-routing') is None: | ||
| self.log('Requirement FAILED: NSR is not Enabled in configuration') | ||
| return False | ||
| self.log('Verifying that NSR is configured on the current Routing Engine\n' |
There was a problem hiding this comment.
Suggest changing to: self.log('Verifying that GRES status on the current Routing Engine\n'
| @@ -248,11 +253,6 @@ def _issu_requirement_validation(self): | |||
| * The master Routing Engine and backup Routing Engine must be | |||
| running the same software version before you can perform a | |||
| unified ISSU. | |||
There was a problem hiding this comment.
Add:
- All checks from _issu_nssu_requirement_validation()
function added _issu_nssu_requirement_validation