Improved matching of paths with spaces for (Windows, macOS, Linux) #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is related to JunoLab/Juno.jl#421 and improves on the previous PR JunoLab#320 to better handle paths with spaces in Juno REPL for Windows, macOS and Linux.
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
+ Coverage 54.95% 56.90% +1.95%
==========================================
Files 42 42
Lines 2615 2504 -111
==========================================
- Hits 1437 1425 -12
+ Misses 1178 1079 -99
Continue to review full report at Codecov.
|
|
Would you mind adding (more) test cases you posted on JunoLab/atom-julia-client#734 (comment) ? |
Added new test cases for path handling in Win / macOS / Linux.
Done. Added many test cases for Win and macOS / Linux. |
|
nice, great work ! CI failures on nightly is unrelated to this PR (it happens on other repositories as well) so ignore that. |
aviatesk
reviewed
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is related to JunoLab/Juno.jl#421 and improves on the previous PR #320 to better handle paths with spaces in Juno REPL for Windows, macOS and Linux. Among other things, it correctly handles extension-less filenames and newline. However, it doesn't fully match the following (so avoid):
1- If you start with a folder name with spaces (obviously). See example 1 in the avoid section.
2- If you have extension-less filename with spaces. See examples 2 and 3 in the avoid section.
3- If you have file extension with spaces. See examples 4 and 5 in the avoid section.
Related PR: JunoLab/atom-julia-client#734
Examples for Windows
Examples for macOS / Linux:
