-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the webio dep code in Blink #174
Conversation
@pfitzseb or @MikeInnes could you please review? Thank you. |
This looks generally fine, but it might be better to use the code in WebIO#master and require WebIO@0.5 instead (that release will probably be out today). If this is time critical we could also merge this as is and release a new Blink version before WebIO is updated though (but then you should add an upper bound on WebIO). |
Thanks for looking into this, Ranjan! So I ran into this problem from here: Is that the same as what you're referring to? That said, I still think this PR is still beneficial! It seems weird to have Blink specifically logic conditionally defined in |
EDIT: nvm apparently they need to be in the (Regarding the static compilation, i think the other part of the problem is that those lines are in the Maybe we should open a PR over there to move them out of |
JK please ignore the above: https://github.com/MikeInnes/Requires.jl:
:( |
Apologies for not getting to this sooner, but I have made the relevant PR on WebIO, so we could potentially merge this and JuliaGizmos/WebIO.jl#232 and tag new releases for both packages. |
This was usurped by #201 and should be closed. |
Currently WebIO uses Requires.jl to interface with Blink. However, we currently can't statically compile packages that use Requires.jl.
This helps support for shipping statically compiled Blink apps.