Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport several changes from REPL.REPLCompletions #16

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

Merging #16 (51beb31) into master (f4b049e) will decrease coverage by 0.73%.
The diff coverage is 64.00%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   57.71%   56.98%   -0.73%     
==========================================
  Files           1        1              
  Lines         428      444      +16     
==========================================
+ Hits          247      253       +6     
- Misses        181      191      +10     
Flag Coverage Δ
unittests 56.98% <64.00%> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/FuzzyCompletions.jl 56.98% <64.00%> (-0.73%) ⬇️

@pfitzseb pfitzseb requested a review from aviatesk October 7, 2023 17:36
@Pangoraw
Copy link
Contributor Author

Pangoraw commented Oct 9, 2023

I am not sure what should the return value of field_completion_eligible should be before 1.10, can the same method test be written ?

@fonsp
Copy link
Contributor

fonsp commented Oct 18, 2023

@aviatesk Could you take a look when you have time?

@aviatesk
Copy link
Member

Thanks!

@aviatesk aviatesk merged commit da79850 into JunoLab:master Oct 25, 2023
15 of 20 checks passed
@fonsp fonsp mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants