Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix julia 1.6 tests #18

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Fix julia 1.6 tests #18

merged 2 commits into from
Mar 13, 2024

Conversation

fonsp
Copy link
Contributor

@fonsp fonsp commented Mar 12, 2024

This fixes some test failures from future Julia API introduced in #16

It looks like the inferrability tests is still breaking, I traced it back to this line:

return complete_any_methods(ex_org, callee_module::Module, context_module, moreargs, shift), (0:length(rexm.captures[1])+1) .+ rexm.offset, false

If you uncomment it then the inference test passes, I don't know how to fix it.

@pfitzseb
Copy link
Member

Let's just disable the inference tests on 1.6?

@fonsp
Copy link
Contributor Author

fonsp commented Mar 13, 2024

good idea!

@pfitzseb pfitzseb merged commit a8df7ae into JunoLab:master Mar 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants