Skip to content

Commit

Permalink
switch to ansi_up, better ansi->HTML conversions
Browse files Browse the repository at this point in the history
  • Loading branch information
pfitzseb committed Jul 22, 2018
1 parent 2046c61 commit 14d270e
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 28 deletions.
5 changes: 2 additions & 3 deletions lib/console/view.coffee
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
ResizeDetector = require 'element-resize-detector'
AnsiConverter = require 'ansi-to-html'
ansiToHTML = require '../util/ansitohtml'
{throttle, delay} = require 'underscore-plus'
converter = new AnsiConverter()

class ConsoleElement extends HTMLElement
createdCallback: ->
Expand Down Expand Up @@ -169,7 +168,7 @@ class ConsoleElement extends HTMLElement
out = document.createElement 'div'
item.ansi = ansi
out.innerText = item.text
out.innerHTML = converter.toHtml(out.innerHTML) if ansi
out.innerHTML = ansiToHTML(out.innerHTML) if ansi
out.classList.add type, 'stream'
out

Expand Down
14 changes: 2 additions & 12 deletions lib/editor/result-view.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
'use babel'
import { CompositeDisposable } from 'atom'
import AnsiConverter from 'ansi-to-html'
import views from '../util/views'
import ansiToHTML from '../util/ansitohtml'

let { span, div } = views.tags
let converter = new AnsiConverter()

export default class ResultView {
constructor (model, opts = {}) {
Expand Down Expand Up @@ -105,16 +104,7 @@ export default class ResultView {
error ? this.view.classList.add('error') : this.view.classList.remove('error')
loading ? this.view.classList.add('loading') : this.view.classList.remove('loading')

if (view.childElementCount == 0) {
view.innerHTML = converter.toHtml(view.innerHTML)
} else if (view.getElementsByTagName) {
let allNodes = view.getElementsByTagName('*')
for (let i = -1, l = allNodes.length; ++i < l;) {
if (allNodes[i].childElementCount == 0) {
allNodes[i].innerHTML = converter.toHtml(allNodes[i].innerHTML)
}
}
}
ansiToHTML(view)

this.view.appendChild(view)

Expand Down
1 change: 1 addition & 0 deletions lib/ink.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,4 @@ module.exports = Ink =
InkTerminal: InkTerminal
Linter: Linter
matchHighlighter: require './util/matchHighlighter'
ansiToHTML: require './util/ansitohtml'
18 changes: 18 additions & 0 deletions lib/util/ansitohtml.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use babel'

import AnsiUp from 'ansi_up'
let converter = new AnsiUp()

export default function ansiToHTML (view) {
if (view.childElementCount == 0) {
view.innerHTML = converter.ansi_to_html(view.innerHTML)
} else if (view.querySelectorAll) {
let allNodes = view.querySelectorAll ('*')
for (let i = -1, l = allNodes.length; ++i < l;) {
if (allNodes[i].childElementCount == 0) {
allNodes[i].innerHTML = converter.ansi_to_html(allNodes[i].innerHTML)
}
}
}
return view
}
16 changes: 4 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"atom": ">=1.12.0 <2.0.0"
},
"dependencies": {
"ansi-to-html": "^0.6.3",
"ansi_up": "^3.0.0",
"atom-space-pen-views": "^2.0.0",
"fuzzaldrin-plus": "^0.1.0",
"underscore-plus": "^1.6.6",
Expand Down

0 comments on commit 14d270e

Please sign in to comment.