Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline results can cover executed code #107

Closed
carocad opened this issue Dec 22, 2016 · 5 comments
Closed

inline results can cover executed code #107

carocad opened this issue Dec 22, 2016 · 5 comments

Comments

@carocad
Copy link
Contributor

carocad commented Dec 22, 2016

While using proto-repl I noticed that if I have a right pane and I evaluate something inline there, the inline atom-ink result would use all the space necessary for its display. This can get quite annoying if you evaluate lots of stuff inline since you lose sigh of the code that you executed.

A picture is better than a thousand words ;)

captura de pantalla de 2016-12-22 15-57-18

As you can see on line 13 and 14 of the right pane, the inline result is covering the code that I used to evaluate it. On line 4 on the other hand everything is fine since it has enough space to display the result.

Atom: 1.9.8
Ink: 0.6.2

@pfitzseb
Copy link
Member

I think this should be fixed by atom/atom#11852, haven't tried it yet though.

@pfitzseb
Copy link
Member

Yes, this does indeed work as expected in 1.14! 🎉

@carocad
Copy link
Contributor Author

carocad commented Jan 12, 2017

@pfitzseb I assume that I would need an atom dev version to test those changes right? because at least in my atom version it doesnt work :(

@pfitzseb
Copy link
Member

pfitzseb commented Jan 12, 2017

Yeah, 1.14 isn't released yet -- you can just clone atom and build it yourself with something like node script/build --build-dir=out --no-install.

@MikeInnes
Copy link
Member

1.14 is out so this is fixed. Still some issues around inline results but we'll keep pushing on those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants