Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug file #683

Merged
merged 12 commits into from Feb 15, 2020
Merged

debug file #683

merged 12 commits into from Feb 15, 2020

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Feb 10, 2020

@pfitzseb
Copy link
Member Author

Peek 2020-02-10 16-57

@aviatesk
Copy link
Member

Do you want

  • tool-bar icon for invoking file debugging ?
  • menus ?

@pfitzseb
Copy link
Member Author

Ah, right, forgot about that. We can now also add commands to debug the currently selected block etc.

@aviatesk
Copy link
Member

We can now also add commands to debug the currently selected block

Maybe Julia Debug: Run Block and Julia Debug: Step Through Block ?

@pfitzseb
Copy link
Member Author

Yeah, that sounds goood.

@aviatesk
Copy link
Member

We can now also add commands to debug the currently selected block

Maybe Julia Debug: Run Block and Julia Debug: Step Through Block ?

Done ;) Also added Run Cell and Step Through Cell.

@aviatesk
Copy link
Member

@pfitzseb don't you mind renaming run-and-move to run-block-and-move ?

@aviatesk
Copy link
Member

As for menus, how about those submenus Run and Debug ?:
image

@pfitzseb
Copy link
Member Author

pfitzseb commented Feb 15, 2020

Improved UI:
image

@pfitzseb
Copy link
Member Author

@pfitzseb don't you mind renaming run-and-move to run-block-and-move ?

Mh, I'd like to keep commands that are likely used by others the same, but maybe it's fine to rename this one.

As for menus, how about those submenus Run and Debug ?:

I don't like deeply nested menus much. Imho the current structure is still fine (and we don't have too many items yet).

@aviatesk
Copy link
Member

Mh, I'd like to keep commands that are likely used by others the same, but maybe it's fine to rename this one.

Yeah, this may break some user's own keybinding. Suggested because you did some renaming around debugging commands, but yes run-and-move is so much often used that them I guess.

I don't like deeply nested menus much. Imho the current structure is still fine (and we don't have too many items yet).

Okay, let's just keep menus then.

@pfitzseb pfitzseb merged commit 4600251 into master Feb 15, 2020
@pfitzseb pfitzseb deleted the sp/debugfile branch February 15, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants