recover OS notification #736
Open
+22
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
electron/electron#18701 is the upstream issue -- seems like it's only been fixed very recently and I don't think the new Electron version has propagated to Atom yet. |
|
okay. I started to use Juno for tasks including time consuming computation, and I found I really want this OS notification. (P.S. I also really can't reproduce the crash on my macOS Mojave 10.14.6 even when calling |
|
It's probably fine to re-enable this fi we can test it on all platforms and keep it behind a setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS notifications is still an issue ?
Searching in atom repo, there seems to be a problem in tree-view stuff in electron<4 on macOS, but couldn't find an issue related to OS notification.