This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVICE-123 - Fetch more detailed mobile device information #143
+785
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Device entities Also added lastSeenOn
mknoedel
commented
Jun 15, 2023
| /** | ||
| * Requires "Read - Mobile Devices" permission | ||
| */ | ||
| public async fetchMobileDeviceById(id: number): Promise<MobileDeviceDetail> { |
There was a problem hiding this comment.
Much like the computers endpoint, you need to individually call the detail view on mobile devices to get most of what we care about.
mknoedel
commented
Jun 15, 2023
Comment on lines
+36
to
+43
| const extensionAttributes = {}; | ||
|
|
||
| // Prevent all extensionAttributes from being uploaded due to the size of the | ||
| // entities that can be generated as a result from uploading every property. | ||
| if (deviceDetail && deviceDetail.extension_attributes) { | ||
| extensionAttributes[`extensionAttribute.${DEPLOYMENT_STATUS}`] = | ||
| getDeploymentStatus(deviceDetail.extension_attributes); | ||
| } |
There was a problem hiding this comment.
This was taken from the createComputerEntity and it looks like the extension properties are the same for mobile devices if you check the recordings.
mknoedel
commented
Jun 15, 2023
Comment on lines
+259
to
+262
| lastSeenOn: parseTimePropertyValue( | ||
| detailData?.general?.last_contact_time_epoch ?? device.report_date_epoch, | ||
| 'ms', | ||
| ), |
There was a problem hiding this comment.
Default to the report_date_epoch when we don't have detail data.
mknoedel
changed the title
adam-in-ict
approved these changes
Jun 16, 2023
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
Fetch more detailed information about mobile devices and add it to the mobile Device entities. Also added lastSeenOn.
Type of change
Please leave any irrelevant options unchecked.
not work as expected)
Checklist
General Development Checklist:
Integration Development Checklist:
Please leave any irrelevant options unchecked.
endpoints, and have documented any additional permissions in
jupiterone.md, where necessary.API
using
dependsOnJupiterOne data model
to ensure that any new entities/relationships, and relevant properties,
match the recommended model for this class of data
CHANGELOG.mdfile to describe my changesreviewed all existing managed questions referencing the entities,
relationships, and their property names, to ensure those questions still
function with my changes.