Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add users step #1

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Add users step #1

merged 2 commits into from
Aug 4, 2023

Conversation

geovannimp
Copy link
Contributor

No description provided.

generateRelationshipType,
} from '@jupiterone/integration-sdk-core';

export const createEntityKey = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this 🎉

return `${entityMetadata._type}:${id}`;
};

export const generateRelationshipMetadata = ({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nifty helper!

ORGANIZATION: 'fetch-organization',
TEAM: 'fetch-teams',
PROJECT: 'fetch-projects',
};
USERS: 'fetch-users',
} satisfies Record<string, `fetch-${string}`>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧠

@@ -29,19 +33,22 @@ export const Entities: Record<
_type: 'linear_project',
_class: ['Project'],
},
};
} satisfies Record<string, StepEntityMetadata>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to figure out if we could make this stricter so it would check for the keys from Steps

src/types.ts Outdated Show resolved Hide resolved
Copy link
Member

@jzolo22 jzolo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 nothing blocking, just a couple curiosity questions

@geovannimp
Copy link
Contributor Author

fire nothing blocking, just a couple curiosity questions

@jzolo22 All addressed

@jzolo22 jzolo22 merged commit 6adb85e into sdk Aug 4, 2023
2 of 5 checks passed
@jzolo22 jzolo22 deleted the users-step branch August 4, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants