Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aws-config.json #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update aws-config.json #69

wants to merge 1 commit into from

Conversation

BrendanQuinnJ1
Copy link

mfa does not need to be enabled on aws_iam_user without a passwordEnabled The original version of this query was returning false positives including aws_iam_useer without the ability to login with a password. key access does not require mfa.

QA Checklist

Alerts Rule Packs

  • Does a related alert already exist, and should it be tweaked or added to instead?
  • Test each query to make sure it works
  • Look for hardcoded variables/parameter values in the query
  • Consider Severity for Alerts
  • Spellcheck
  • Use all caps for J1QL keywords and relationship classes
  • Upload the alerts rule pack JSON into JupiterOne to validate

@BrendanQuinnJ1
Update aws-config.json
4afdd44 
mfa does not need to be enabled on aws_iam_user without a passwordEnabled The original version of this query was returning false positives including aws_iam_useer without the ability to login with a password. key access does not require mfa.
@BrendanQuinnJ1 BrendanQuinnJ1 requested review from a team as code owners June 30, 2022 21:33
@BrendanQuinnJ1 BrendanQuinnJ1 requested a review from a team June 30, 2022 21:33
@FrancesCoronel
Copy link

Is it fine to close this PR?

@a-u-h-g
Copy link
Contributor

a-u-h-g commented Mar 30, 2023

this is a good change would need to be pushed through to alert pack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-u-h-g a-u-h-g a-u-h-g approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BrendanQuinnJ1 @FrancesCoronel @a-u-h-g