Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[review] Fix volume not update until song finishes #1901

Merged

Conversation

Projects
None yet
2 participants
@TheerapakG
Copy link
Collaborator

commented May 12, 2019

After creating your pull request, tick these boxes if they are applicable to you.

  • I have tested my changes against the review branch (the latest developmental version), and this pull request is targeting that branch as a base
  • I have tested my changes on Python 3.5.3 or higher

Description

Fix volume not update until the song finishes due to the addition of source in #1892.

Related issues (if applicable)

@TheerapakG TheerapakG requested a review from jaydenkieran as a code owner May 12, 2019

@TheerapakG TheerapakG force-pushed the TheerapakG:bug_rv_volumenotupdate branch from 305c545 to f6b482d May 12, 2019

@jaydenkieran jaydenkieran merged commit 2801622 into Just-Some-Bots:review May 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.