Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review existing automatic strings upload to crowdin on-commit via CI #943

Closed
2 tasks done
JustArchi opened this issue Nov 9, 2018 · 2 comments
Closed
2 tasks done

Review existing automatic strings upload to crowdin on-commit via CI #943

JustArchi opened this issue Nov 9, 2018 · 2 comments
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. ⛔ On hold Issues marked with this label are blocked from being worked on, very often due to third-parties.

Comments

@JustArchi
Copy link
Member

JustArchi commented Nov 9, 2018 •
edited
Loading

ASF currently does itself, ASF-ui, ASF-WebConfigGenerator and wiki on each commit.

First step is automating UI and WCG (they can do it themselves), then deciding what to do with the wiki.

Prereqs:
@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. ⛔ On hold Issues marked with this label are blocked from being worked on, very often due to third-parties. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. labels Nov 9, 2018
@JustArchi JustArchi added 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. and removed ⛔ On hold Issues marked with this label are blocked from being worked on, very often due to third-parties. labels Nov 16, 2018
JustArchi added a commit that referenced this issue Nov 16, 2018
@JustArchi
Upgrade my crowdin magic to ArchiCrodwin in preparation for #943
1ea9e72
@JustArchi JustArchi added ⚪ No priority Issues marked with this label are not being actively worked on for time being. and removed 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. labels Dec 14, 2018
@JustArchi JustArchi added ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. and removed ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. labels Jan 12, 2019
@JustArchi
Copy link
Member Author

There is a chance that wiki could be nicely automated thanks to https://github.com/dependabot/feedback/issues/301

@JustArchi JustArchi added ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. ⛔ On hold Issues marked with this label are blocked from being worked on, very often due to third-parties. and removed ⚪ No priority Issues marked with this label are not being actively worked on for time being. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. labels May 26, 2019
@JustArchi
Copy link
Member Author

JustArchi commented Aug 3, 2020 •
edited
Loading

With the above commit, strings upload (and download) is now nicely automated:

  • GitHub action uploads strings to translate on each commit to master branch.
  • For main ASF repo, the above also includes the wiki.
  • Change on the wiki will trigger dependabot to update the submodule (daily), creating a commit which will trigger the above.
  • GitHub cron action will periodically download the translations back to the repo, including wiki (and commit them), currently this happens each day.
  • If by any chance dependabot misses the wiki, cron action will fix the wiki to latest master "by the way" while handling translations, since we need to commit on fresh source anyway.

ASF-ui and ASF-WebConfigGenerator follow the same idea, except they don't need to worry about any wiki to begin with, simplifying the work done.

The only potential improvement that is left is live submodules update which perhaps at some point will be added in https://github.com/dependabot/feedback/issues/301 - until then, instant upload of source strings and daily upload of wiki strings sounds good enough to me to close this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. ⛔ On hold Issues marked with this label are blocked from being worked on, very often due to third-parties.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JustArchi