Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchoring InfoWindow children of Markers #879

Merged

Conversation

SpangleLabs
Copy link
Contributor

Please explain PR reason.

This is to resolve #10

It allows putting an InfoWindow as a child of a Marker, and having the infowindow automatically anchored to the marker.

@SpangleLabs SpangleLabs changed the title Infowindow children of marker Anchoring InfoWindow children of Markers May 12, 2020
@SpangleLabs
Copy link
Contributor Author

SpangleLabs commented May 12, 2020

Here's some example code of it working, in a gist:
https://gist.github.com/joshcoales/d89a2f947b9c3b3c4ddafaebfca1df6b
The imports are messy so I could get it working locally.. There's probably a cleaner way!

Copy link
Owner

@JustFly1984 JustFly1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please externalize interface, and I will merge and publish new version

@SpangleLabs
Copy link
Contributor Author

There we go, pulled out that interface in 6fddef0

@JustFly1984 JustFly1984 merged commit 803e1b1 into JustFly1984:master May 29, 2020
fakhririzha pushed a commit to icubebysirclo/react-google-maps-api that referenced this pull request Mar 31, 2022
…n-of-marker

Anchoring InfoWindow children of Markers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow InfowWindow anchor to be a <Marker/> component
2 participants