Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction tooltips missing on "Releases" page / Missing tooltips for Editor's toolbar buttons #54

Closed
Vangelis66 opened this issue Mar 7, 2022 · 14 comments
Labels
bug Something isn't working fixed

Comments

@Vangelis66
Copy link

Vangelis66 commented Mar 7, 2022

Browser: Latest (UXP-based) Serpent 52.9.0 (2022-02-25) (32-bit)
Browser profile: Fresh/clean one (with default settings), only this extension installed
Extension version: Latest release, i.e. v1.12.15

STR

  1. Make sure you're already signed-in, as this GitHub feature is reserved for GitHub members...
  2. Load e.g. https://github.com/SeaHOH/github-wc-polyfill/releases
    In the "reactions" area, just below "Assets", you'll see that (at the time of this writing) 6 members have reacted with 👍 and another with a ❤️ emoji.
  3. Place the cursor on top of either reaction;
    expected behaviour: A tooltip containing the usernames of the members that reacted similarly:

tooltip

(the above was taken with a Chromium-derived browser)

actual behaviour: No tooltip is being displayed:

tooltip2

(St52+gh-wc-pf-1.12.15)

NB: "Reaction" tooltips are being displayed correctly on Comment reactions...

Addendum:

It later emerged that the GitHub editor's toolbar buttons are similarly affected, i.e.

  1. Scroll down this page to find the "New Comment" input field (you also need to be signed-in).
  2. Hover with the cursor over one of the editor's toolbar buttons,

c3

expected behaviour: A tooltip pops-up, explaining the function of selected button:

c4

(Chromium-derived browser)

actual behaviour: Tooltip missing:

c2

(St52+gh-wc-pf-1.12.15)

@SeaHOH SeaHOH added the bug Something isn't working label Mar 7, 2022
@SeaHOH
Copy link
Collaborator

SeaHOH commented Mar 7, 2022

I can't find the reason. A style as dirty fix is:

.hx_tooltip {
  position: static !important;
  opacity: 1 !important;
}

@SeaHOH SeaHOH added the help wanted Extra attention is needed label Mar 7, 2022
@AroKol78
Copy link

AroKol78 commented Mar 7, 2022

for uBo
github.com##.hx_tooltip:style(opacity: 1 !important;) 👍 it's just my opinion
or (a little different effect)
github.com##.hx_tooltip:style(position: static !important; opacity: 1 !important;)

pic1:

bughh0021

@Vangelis66
Copy link
Author

Thanks for investigating this 👍 ; I still hope a proper solution will present itself in due course... 😉

for uBO:

github.com##.hx_tooltip:style(position: static !important; opacity: 1 !important;)

Unfortunately, that one, as well as the CSS style proposed by SeaHOH do also affect other GH regions, e.g. the position of tooltips that pop-up when hovering over the comment editor's toolbar buttons:

C1

which, I have come to realise now, are also plagued by that very same bug 😠 ...

@Vangelis66 Vangelis66 changed the title Reaction tooltips missing on "Releases" page Reaction tooltips missing on "Releases" page / Missing tooltips for Editor's toolbar buttons Mar 7, 2022
@Vangelis66
Copy link
Author

Vangelis66 commented Mar 7, 2022

First post as well as issue's title have been updated...

@SeaHOH
Copy link
Collaborator

SeaHOH commented Mar 8, 2022

Is this more better?

markdown-toolbar > div, .js-pick-reaction > div {
  position: relative !important;
}
.hx_tooltip {
  opacity: 1 !important;
  bottom: 110% !important;
  left: 0 !important;
}

@AroKol78
Copy link

AroKol78 commented Mar 8, 2022

it's OK

pic1:

isokgh001

@Vangelis66
Copy link
Author

Is this more better?

It certainly is a compromise one could live with... 👍 😄

FTR, in Chromium every button in the editor's toolbar spawns its own tooltip when hovered, displayed slightly below said button (see opening post, 4th attached screenshot); with that latest userstyle, every 3 successive buttons, starting from left to right (1-3, 4-6, 7-9, 10-12), share the same tooltip position, displayed slightly above the button(s) ...

As for Releases reaction tooltips, these are now displayed above the emojis, which is closer to what Chromium does... 👍

At the end of the day, without me nitpicking 😜 , all required information (provided by the tooltips) is indeed displayed in an acceptable fashion, so, unless somebody has an "epiphany" on the actual root cause of this bug in UXP, "we" could settle for such a CSS workaround...
Many thanks!

@SeaHOH
Copy link
Collaborator

SeaHOH commented Mar 9, 2022

github-wc-polyfill-1.2.16b2
I caught it, an attribute issue by named hidden.

@SeaHOH SeaHOH added fixed and removed help wanted Extra attention is needed labels Mar 9, 2022
@Vangelis66
Copy link
Author

I caught it, an attribute issue by named hidden

👍 🥇 🎉 🚀 :

F2

F1

(St52+gh-wc-pf-1.2.16b2)

... Someone did have an epiphany, for sure! 😄
Closing this, thanks...

@AroKol78
Copy link

nothing serious
when deleting an earlier comment (ST52 + 1.2.16)

pic1:

gh002bug

@Vangelis66
Copy link
Author

when deleting an earlier comment (ST52 + 1.2.16)

I can replicate 👍 :

b1

; but why do you think it's related to this closed issue?
I get the same result with 1.2.16b1, too, which doesn't contain the "fix" for #54 ...

Additionally, when I actually delete a comment revision, the whole webpage reloads 😠 ; not sure whether it's a bug or intended behaviour...
How do latest Chrome/Firefox act in that regard (I can't test in this laptop now...) ?
If they do it differently, perhaps I (or someone else 😜 ) should file a new, separate, issue ...

@AroKol78
Copy link

it just gives a signal that something like that is (i don't even know if it's specific to UXP only)

@Vangelis66
Copy link
Author

I know the extension has been abandoned now, however, for clarity reasons, this original issue has, as of the first week of Aug 2022, come back now 😡, involving ALL GH tooltips, i.e. both the Editor's toolbar buttons as well as reaction tooltips on comments/releases...

Anyone willing to take a look, please chime in... 😉

@Vangelis66
Copy link
Author

The issue has been successfully resolved a second time, by @roytam1, by backporting fixes from the currently maintained fork, palefill 🎉 ...
For the updated source code, look at:
roytam1@1a0d796
For compiled source, i.e. an .XPI file, look here 👍 .

Many thanks to all the devs (roytam1, SeaHOH, martok) involved! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

3 participants