New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reaction tooltips missing on "Releases" page / Missing tooltips for Editor's toolbar buttons #54
Comments
I can't find the reason. A style as dirty fix is: .hx_tooltip {
position: static !important;
opacity: 1 !important;
} |
Thanks for investigating this 👍 ; I still hope a proper solution will present itself in due course... 😉
Unfortunately, that one, as well as the CSS style proposed by SeaHOH do also affect other GH regions, e.g. the position of tooltips that pop-up when hovering over the comment editor's toolbar buttons: which, I have come to realise now, are also plagued by that very same bug 😠 ... |
First post as well as issue's title have been updated... |
Is this more better? markdown-toolbar > div, .js-pick-reaction > div {
position: relative !important;
}
.hx_tooltip {
opacity: 1 !important;
bottom: 110% !important;
left: 0 !important;
} |
It certainly is a compromise one could live with... 👍 😄 FTR, in Chromium every button in the editor's toolbar spawns its own tooltip when hovered, displayed slightly below said button (see opening post, 4th attached screenshot); with that latest userstyle, every 3 successive buttons, starting from left to right (1-3, 4-6, 7-9, 10-12), share the same tooltip position, displayed slightly above the button(s) ... As for Releases reaction tooltips, these are now displayed above the emojis, which is closer to what Chromium does... 👍 At the end of the day, without me nitpicking 😜 , all required information (provided by the tooltips) is indeed displayed in an acceptable fashion, so, unless somebody has an "epiphany" on the actual root cause of this bug in UXP, "we" could settle for such a CSS workaround... |
github-wc-polyfill-1.2.16b2 |
I can replicate 👍 : ; but why do you think it's related to this closed issue? Additionally, when I actually delete a comment revision, the whole webpage reloads 😠 ; not sure whether it's a bug or intended behaviour... |
it just gives a signal that something like that is (i don't even know if it's specific to UXP only) |
I know the extension has been abandoned now, however, for clarity reasons, this original issue has, as of the first week of Aug 2022, come back now 😡, involving ALL GH tooltips, i.e. both the Editor's toolbar buttons as well as reaction tooltips on comments/releases... Anyone willing to take a look, please chime in... 😉 |
The issue has been successfully resolved a second time, by @roytam1, by backporting fixes from the currently maintained fork, Many thanks to all the devs (roytam1, SeaHOH, martok) involved! ❤️ |
Browser: Latest (UXP-based) Serpent 52.9.0 (2022-02-25) (32-bit)
Browser profile: Fresh/clean one (with default settings), only this extension installed
Extension version: Latest release, i.e. v1.12.15
STR
In the "reactions" area, just below "Assets", you'll see that (at the time of this writing) 6 members have reacted with 👍 and another with a ❤️ emoji.
expected behaviour: A tooltip containing the usernames of the members that reacted similarly:
(the above was taken with a Chromium-derived browser)
actual behaviour: No tooltip is being displayed:
(St52+gh-wc-pf-1.12.15)
NB: "Reaction" tooltips are being displayed correctly on Comment reactions...
Addendum:
It later emerged that the GitHub editor's toolbar buttons are similarly affected, i.e.
expected behaviour: A tooltip pops-up, explaining the function of selected button:
(Chromium-derived browser)
actual behaviour: Tooltip missing:
(St52+gh-wc-pf-1.12.15)
The text was updated successfully, but these errors were encountered: