Reaction tooltips missing in GitHub #22
Comments
|
"Vielen Dank" for your prompt action! 👍
|
|
That's actually Github screwing it up. The elements get the |
Yes 😠 ... I can easily reproduce with a recent-ish Chromium-based browser, too 😞 ...
|
|
How typical of Microsoft... 😠 😡 The misplaced "reaction emoji selection panel" reported by @NEO-SPECTRUMAN appears to have been now fixed:
... however, this original issue has now come back with a vengeance 😡, This issue should be re-opened and revisited... Later EDIT: I also forgot to note that ALL GH tooltips are now seemingly affected (i.e. have vanished), including GH Editor's toolbar buttons (like when typing/editing this very comment):
|
|
Patches below fixed the new issue. Lines 333 to 350 in 2d141c1 return !context ? !selectors ? tagName :
\`\${tagName}:-moz-any(\${selectors})\` :
\`:-moz-any(\${selectors}) \${tagName}\`;
}) + style;
}
}
}
};
const observer = new MutationObserver(function(mutations) {
for (const {target, attributeName, oldValue} of mutations) {
target.attributeChangedCallback(attributeName, oldValue, target.getAttribute(attributeName));
}
}),
asNames = new Set(["article", "aside", "blockquote", "body", "div",
"footer", "h1", "h2", "h3", "h4", "h5", "h6",
"header", "main", "nav", "p", "section", "span"]);
Element.prototype.attachShadow = function attachShadow(init) {
// customElements observe Shadow failed, so re-start observe here
const {observedAttributes} = this.__CE_definition || {};
if (observedAttributes) {
observer.observe(this, {
attributes: true,
attributeOldValue: true,
attributeFilter: observedAttributes
});
}
if (this.shadowRoot !== undefined) |
|
Makes sense, that fits with how far I managed to narrow the problem down. Thank you, will apply later! |
|
Between The date/time while writing this comment is ca. Do you know what the current outcome is? I have been very careful at properly applying the patches onto file polyfills.js of snapshot 2d141c1, so, hopefully, it isn't something caused by me messing up things (but I can never rule it out 😜 ...). Latest TL;DR: As of this time, proposed "fixes" do not remedy this issue... 😭 |
|
One line has been missed, it's OK now. |
|
... Thanks for your prompt reply 😄 ! --- a.polyfills.js 2022-08-04 00:32:21.000000000 +0300
+++ b.polyfills.js 2022-08-09 21:14:20.477000000 +0300
@@ -330,23 +330,32 @@
// flag "s" is broken in SeaMonkey
/:host(-context)?(?:\\(([\\s\\S]+?)\\))?/g,
function ($, context, selectors) {
- if (context === undefined && selectors === undefined)
- return tagName;
- if (context)
- return \`:-moz-any(\${selectors}) \${tagName}\`;
- let res = [];
- for (let selector of selectors.split(","))
- res.push(tagName + selector);
- return \`:-moz-any(\${res.join(", ")})\`;
+ return !context ? !selectors ? tagName :
+ \`\${tagName}:-moz-any(\${selectors})\` :
+ \`:-moz-any(\${selectors}) \${tagName}\`;
}) + style;
}
}
}
};
- const asNames = new Set(["article", "aside", "blockquote", "body", "div",
+ const observer = new MutationObserver(function(mutations) {
+ for (const {target, attributeName, oldValue} of mutations) {
+ target.attributeChangedCallback(attributeName, oldValue, target.getAttribute(attributeName));
+ }
+ }),
+ asNames = new Set(["article", "aside", "blockquote", "body", "div",
"footer", "h1", "h2", "h3", "h4", "h5", "h6",
"header", "main", "nav", "p", "section", "span"]);
Element.prototype.attachShadow = function attachShadow(init) {
+ // customElements observe Shadow failed, so re-start observe here
+ const {observedAttributes} = this.__CE_definition || {};
+ if (observedAttributes) {
+ observer.observe(this, {
+ attributes: true,
+ attributeOldValue: true,
+ attributeFilter: observedAttributes
+ });
+ }
if (this.shadowRoot !== undefined)
throw new DOMException(
\`The <\${this.tagName}> element has be tried to attach to is already a shadow host.\`,compiled locally source to .XPI, installed and can verify now things are OK:
|
|
Thank you two! |
😡 ; just a short while ago, I bumped into one more such instance which hasn't been fixed; it's "Conversations" as part of PRs... STR
Really? How incompetent are they at Microsoft currently? 👎 😞 |
|
UserCSS: .dropdown-menu-reactions.dropdown-menu-w {
float: left;
left: 0px;
top: -180%;
width: -moz-fit-content; /* or 1000% */
/* uncomment for specific bg colour
background-color: black;
*/
}For browsers that we don't care about: https://stackoverflow.com/questions/7839164/is-there-a-css-cross-browser-value-for-width-moz-fit-content. |
|
Thanks for that userstyle 😄 ; I've tried it, and while it does now allow for (un-)reacting, it appears as an "ugly" kludge (which is still better than nothing 😉 ) in my case:
(among other things, the panel's background is transparent, etc.). Additionally, I'd need someone to kindly offer the regex needed for the userstyle to be applied selectively on |
|
I suspect this depends on your theme in GH. Mine is "Light high contrast". Insert a line with See the updated CSS above for a more specific fix that doesn't affect the other reaction menus. When applied with Stylem the CSS properties need the |
Your altruistic help is being highly valued here! ❤️
I just tweaked somewhat the
In my case, my current browser (latest Serpent 52.9.0) has kept Fx-52esr-level support for Web Extensions, so I'm using
I, OTOH, use Kindest regards 😄 |
|
... And... UPDATE (this is a bottomless pit 😡 ) ! The praise-worthy solution by dirkf apparently breaks another "emoji-button": ytdl-org/youtube-dl@d231b56#r81169570 ; if you click on the "emoji-button" to react to pukkandan's comment, the emoji selection popup is displayed to the right, but truncated 😞 :
Fortunately, temporarily disabling dirkf's userstyle in Later addition: |
|
just adjust the selector as |
and others
Many thanks for this most valuable extension 👍 .
I'm currently in the process of migrating from
gh-wc-polyfilltopalefill, but stumbled across a bug/irritation:STR
Version of extension:
1.11Update to PM 31.0 #8 (comment)
This is currently working as expected with
gh-wc-polyfill-v1.2.19😉I can also reproduce with latest
palefillALL the problems reported in upstream issue #54: JustOff/github-wc-polyfill#54problems fixed by
JustOff/github-wc-polyfill@c0f5ff3
and
JustOff/github-wc-polyfill@74179c2
Thanks in advance for any eventual resolution... 😄
The text was updated successfully, but these errors were encountered: