fix: do not follow data URIs (#98)

JustinBeckwith · Nov 3, 2019 · f8eefcb · f8eefcb
1 parent e55edb1
commit f8eefcb
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 16 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -51,7 +51,7 @@ export class LinkChecker extends EventEmitter {
    */
   async check(options: CheckOptions) {
     options.linksToSkip = options.linksToSkip || [];
-    options.linksToSkip.push('^mailto:', '^irc:');
+    options.linksToSkip.push('^mailto:', '^irc:', '^data:');
     let server: http.Server | undefined;
     if (!options.path.startsWith('http')) {
       const port = options.port || 5000 + Math.round(Math.random() * 1000);

diff --git a/test/fixtures/mailto/index.html b/test/fixtures/mailto/index.html
diff --git a/test/fixtures/protocols/index.html b/test/fixtures/protocols/index.html
@@ -1,5 +1,7 @@
 <html>
 <body>
   <a href="irc://irc.freenode.net/%23bootstrap">visit us on irc</a>
+  <a href="mailto:email@example.com">send me an email</a>
+  <img src="data:text/plain;charset=utf-8;base64,8J+Qvw==">
 </body>
 </html>
diff --git a/test/test.ts b/test/test.ts
@@ -78,15 +78,6 @@ describe('linkinator', () => {
     requestStub.restore();
   });
 
-  it('should skip mailto: links', async () => {
-    const results = await check({ path: 'test/fixtures/mailto' });
-    assert.ok(results.passed);
-    assert.strictEqual(
-      results.links.filter(x => x.state === LinkState.SKIPPED).length,
-      1
-    );
-  });
-
   it('should report malformed links as broken', async () => {
     const results = await check({ path: 'test/fixtures/malformed' });
     assert.ok(!results.passed);
@@ -131,11 +122,12 @@ describe('linkinator', () => {
   });
 
   it('should not folow non-http[s] links', async () => {
+    // includes mailto, data urls, and irc
     const results = await check({ path: 'test/fixtures/protocols' });
     assert.ok(results.passed);
     assert.strictEqual(
       results.links.filter(x => x.state === LinkState.SKIPPED).length,
-      1
+      3
     );
   });