Fix #69 - Add HashSpillDetails to warnings tooltip section

JustinPealing · Jan 29, 2018 · eb65514 · eb65514
1 parent f6a0c63
commit eb65514
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/src/qp.xslt b/src/qp.xslt
@@ -532,6 +532,9 @@
         <xsl:for-each select="s:Warnings/s:MemoryGrantWarning">
           <div>The query memory grant detected "<xsl:value-of select="@GrantWarningKind" />", which may impact the reliability. Grant size: Initial <xsl:value-of select="@RequestedMemory" /> KB, Final <xsl:value-of select="@GrantedMemory" /> KB, Used <xsl:value-of select="@MaxUsedMemory" /> KB.</div>
         </xsl:for-each>
+        <xsl:for-each select="s:Warnings/s:HashSpillDetails">
+          <div>Hash wrote <xsl:value-of select="@WritesToTempDb" /> pages to and read <xsl:value-of select="@ReadsFromTempDb" /> pages from tempdb with granted memory <xsl:value-of select="@GrantedMemoryKb" />KB and used memory <xsl:value-of select="@UsedMemoryKb" />KB.</div>
+        </xsl:for-each>
       </div>
     </xsl:if>
   </xsl:template>

diff --git a/test/plans.ts b/test/plans.ts
@@ -29,6 +29,7 @@ var plan = {
     UpvotesForEachTag: require('raw-loader!../test_plans/stack overflow/How many upvotes do I have for each tag.sqlplan'),
     unmatched_index: require('raw-loader!../test_plans/unmatched_index.sqlplan'),
     columns_with_no_statistics: require('raw-loader!../test_plans/columns_with_no_statistics.sqlplan'),
-    spilltotempdb: require('raw-loader!../test_plans/spilltotempdb.sqlplan')
+    spilltotempdb: require('raw-loader!../test_plans/spilltotempdb.sqlplan'),
+    HashSpillDetails: require('raw-loader!../test_plans/HashSpillDetails.sqlplan')
 }
 export { plan };
diff --git a/test/tooltip_warning_test.ts b/test/tooltip_warning_test.ts
@@ -86,4 +86,13 @@ describe("Tooltip Warnings Section", () => {
 
     })
 
+    it("Shows HashSpillDetails warning", () => {
+
+        const expected = "Hash wrote 10040 pages to and read 19040 pages from tempdb with granted memory 997376KB and used memory 996656KB.";
+        let container = helper.showPlan(plan.HashSpillDetails);
+        let hashMatch = helper.findNodeById(container, "2");
+        assert.equal(true, helper.getToolTipSection(hashMatch, "Warnings").indexOf(expected) >= 0);
+
+    })
+
 })
diff --git a/test_plans/HashSpillDetails.sqlplan b/test_plans/HashSpillDetails.sqlplan
@@ -92,7 +92,7 @@
                       </OutputList>
                       <Warnings>
                         <SpillToTempDb SpillLevel="1" SpilledThreadCount="8"/>
-                        <HashSpillDetails GrantedMemoryKb="997376" UsedMemoryKb="996656" WritesToTempDb="19040" ReadsFromTempDb="19040"/>
+                        <HashSpillDetails GrantedMemoryKb="997376" UsedMemoryKb="996656" WritesToTempDb="10040" ReadsFromTempDb="19040"/>
                       </Warnings>
                       <MemoryFractions Input="0.5" Output="0.5"/>
                       <RunTimeInformation>