fix: authenticated_user_in_users callsite

Justintime50 · May 15, 2023 · f5706d4 · f5706d4
1 parent b829262
commit f5706d4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## v5.0.3 (2023-05-15)
+
+- Fixes a syntax error that led to not being able to remove the authenticated user from the user's list so their git assets weren't included twice (fixes #55)
+
 ## v5.0.2 (2023-03-25)
 
 - Overhauls subprocess error handling so output is no longer clobbered

diff --git a/github_archive/archive.py b/github_archive/archive.py
@@ -101,7 +101,7 @@ def run(self):
         failed_repo_dirs = []
 
         # Personal (includes personal authenticated items)
-        if self.token and self.authenticated_user_in_users and self.users:
+        if self.token and self.users and self.authenticated_user_in_users():
             logger.info('# Making API call to GitHub for personal repos...')
             personal_repos = self.get_all_git_assets(PERSONAL_CONTEXT)
 
@@ -122,8 +122,7 @@ def run(self):
 
             # We remove the authenticated user from the list so that we don't double pull their
             # repos for the `users` logic.
-            if self.authenticated_username:
-                self.users.remove(self.authenticated_username)
+            self.users.remove(self.authenticated_username)
 
         # Users (can include personal non-authenticated items, excludes personal authenticated calls)
         if self.users and len(self.users) > 0:

diff --git a/setup.py b/setup.py
@@ -24,7 +24,7 @@
 
 setuptools.setup(
     name='github-archive',
-    version='5.0.2',
+    version='5.0.3',
     description=(
         'A powerful tool to concurrently clone, pull, or fork user and org repos and gists to create a GitHub archive.'
     ),