Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rrules for Fermionic symmetries #126

Merged
merged 23 commits into from
Jun 3, 2024

Conversation

qmortier
Copy link
Contributor

rrules for tensorcontract etc for fermions

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.95%. Comparing base (4607691) to head (73992c9).

Current head 73992c9 differs from pull request most recent head 39942c1

Please upload reports for the commit 39942c1 to get more accurate results.

Files Patch % Lines
src/tensors/adjoint.jl 0.00% 2 Missing ⚠️
src/tensors/indexmanipulations.jl 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   81.44%   81.95%   +0.51%     
==========================================
  Files          42       42              
  Lines        5588     5680      +92     
==========================================
+ Hits         4551     4655     +104     
+ Misses       1037     1025      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkdvos lkdvos changed the title fermionic ad stuff Fix rrules for Fermionic symmetries May 28, 2024
@lkdvos
Copy link
Collaborator

lkdvos commented May 28, 2024

I rebased this on the current master and added a few changes that simplify the implementations.

Most notably I added a method for twisting multiple tensor indices at the same time. I'll finish this up tomorrow, but I would like to add:

  • some tests for the vectorized twist I realised later that this is already used in tensorcontract
  • some simplifications in the tensortrace implementation

test/ad.jl Show resolved Hide resolved
test/ad.jl Outdated Show resolved Hide resolved
@Jutho
Copy link
Owner

Jutho commented May 30, 2024

I guess something is off with the random number generator on Julia 1.6 :-)

@lkdvos
Copy link
Collaborator

lkdvos commented May 30, 2024

I am investigating now, but I have no clue what is going on here

@lkdvos
Copy link
Collaborator

lkdvos commented May 30, 2024

So, as far as I can tell, the issue arises whenever the SVD is truncating between two singular values that are close together, such that the FiniteDifferences calls yield different sizes of tensors, which then ofcourse cannot be added.
I changed some of the parameters around, and hope that it works now, but it's definitely not "fixed".

@lkdvos
Copy link
Collaborator

lkdvos commented May 30, 2024

Everything seems to turn green again, ready to go for me!

@lkdvos lkdvos merged commit 7b480fc into Jutho:master Jun 3, 2024

Apply a twist to the `i`th index of `t` and return the result as a new tensor.
Apply a twist to the `i`th index of `tsrc` and return the result as a new tensor.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to mention that the doc string needed an update to reflect the is argument here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants