Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined tol and remove unused variable in QR and LQ pullback #127

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

leburgel
Copy link
Contributor

@leburgel leburgel commented Jun 3, 2024

The gauge dependency checks in qr_pullback! and lq_pullback! threw an error because the check tol was defined in a let block. Also, the ΔR11 variable was unused in both cases, so I removed it.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (7b480fc) to head (9789de2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   81.95%   81.94%   -0.01%     
==========================================
  Files          42       42              
  Lines        5680     5678       -2     
==========================================
- Hits         4655     4653       -2     
  Misses       1025     1025              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkdvos
Copy link
Collaborator

lkdvos commented Jun 3, 2024

I don't think this matters for performance all that much, but in principle you could check if this leads to a "boxed" variable inside of the closure used by findlast. The let block avoids this which could lead to more type stability, but it probably does not make a huge difference. You could check this by descending into it via Cthulhu.jl, which should show some warnings.

@leburgel
Copy link
Contributor Author

leburgel commented Jun 3, 2024

I could check, but if it's anyway safer I could also just put back the let block and redefine the tolerance later when it's used for the check (potentially again in a scoped block, though I don't know if it makes any difference for that specific use). I definitely wasn't thinking about this, just wanted it to run.

In any case, the way I changed it here is exactly the same as what was already happening in the SVD pullback. So if this is something we should be careful with, I can also change it there.

@Jutho Jutho merged commit 1f96764 into Jutho:master Jun 3, 2024
9 of 10 checks passed
@Jutho
Copy link
Owner

Jutho commented Jun 3, 2024

Thanks.

@leburgel leburgel deleted the lb/orth_pullback_fix branch June 4, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants