spacetype abstract types to traits #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 66.91% 67.01% +0.10%
==========================================
Files 38 38
Lines 4887 4939 +52
==========================================
+ Hits 3270 3310 +40
- Misses 1617 1629 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Cannot really seem to figure out why CI fails on windows with julia 1.6? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InnerProductSpaceandEuclideanSpaceas abstract types.InnerProductStyleas a trait based mechanism to query if a space has an inner product.NoInnerProduct,HasInnerProductandEuclideanInnerProductas traitsRemark:
It might be clearer to remove this distinction altogether. I don't know of a current use of
GeneralSpace, which is the only non-Euclidean spacetype to begin with. If we are happy with this design I'll update the docs as well