Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: GitHub Actions setup #303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefantalpalaru
Copy link

Plus a series of CMake-related fixes.

Plus a series of CMake-related fixes.
@JvanKatwijk
Copy link
Owner

I can see the proposed actions for changing the CMakefiles, but I fail to see the purpose - and therefore the need - for the "yml" file

@stefantalpalaru
Copy link
Author

Here's the purpose: stefantalpalaru#1

Same info, with another UI: https://github.com/stefantalpalaru/qt-dab/actions/runs/6537708041?pr=1

Don't you wish you knew that you broke versions 4 and 5 when you renamed "src/scopes-qwt6/iqdisplay.cpp", before doing a release? That's the need for CI, right there.

So you either keep pushing to "master", like a lazy bum, and see what breaks in CI, or you start working in a new Git branch for every new modification, then make a PR from that branch, see if it all still builds, push more commits to it if necessary, then "squash and merge" that PR into "master", like a boss.

Either way, you stop releasing software that doesn't build. You're welcome.

@JvanKatwijk
Copy link
Owner

JvanKatwijk commented Oct 21, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants