Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest version of grafana-tools/sdk #57

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Use latest version of grafana-tools/sdk #57

merged 2 commits into from
Mar 31, 2020

Conversation

K-Phoen
Copy link
Owner

@K-Phoen K-Phoen commented Mar 31, 2020

Fixes #56

@K-Phoen K-Phoen added the patch label Mar 31, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020 •
edited
Loading

Codecov Report

Merging #57 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          24       24           
  Lines        1284     1284           
=======================================
  Hits         1189     1189           
  Misses         70       70           
  Partials       25       25
Impacted Files Coverage Δ
alert/alert.go 100.00% <100.00%> (ø)
alert/condition.go 100.00% <100.00%> (ø)
graph/graph.go 100.00% <100.00%> (ø)

@K-Phoen K-Phoen mentioned this pull request Mar 31, 2020
Closed
@slimsag
Copy link
Contributor

slimsag commented Mar 31, 2020

Aha, i was just about to send a PR, thanks :)

Why does Grabana use a vendor/ directory, instead of just Go modules?

@K-Phoen
Copy link
Owner Author

K-Phoen commented Mar 31, 2020

Why does Grabana use a vendor/ directory, instead of just Go modules?

It's not strictly necessary, I just left the vendor/ dir in the git repo to slightly speedup the CI ¯\_(ツ)_/¯

@K-Phoen K-Phoen merged commit 7a7a837 into master Mar 31, 2020
@K-Phoen K-Phoen deleted the update-grafana-sdk-dep branch March 31, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible with upstream Grafana SDK changes?
2 participants
@K-Phoen @slimsag