Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional gbs filters #5

Merged
merged 2 commits into from
Mar 21, 2018
Merged

Additional gbs filters #5

merged 2 commits into from
Mar 21, 2018

Conversation

VelNZ
Copy link
Contributor

@VelNZ VelNZ commented Mar 21, 2018

Added 2 new GBS filters:

  1. Exclude blocks from query that have an FT or FILTER annotation that does not have a value of PASS.
  2. Exclude blocks from query that are smaller than a size set by the user.

@VelNZ
Adding GBS detailed analysis type descriptions. Adding Exclude Failed…
c828918 
… Variants GBS filter. Adding minimum event size to return GBS filter.
@VelNZ
Rewording the "minimum event size" to "minimum block size" after real…
0aa86d1 
…ising the restriction is on the input block size not the result size.
@VelNZ VelNZ requested a review from drmjc March 21, 2018 05:36
drmjc
drmjc approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@drmjc drmjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v useful. Thanks Vel.

@drmjc drmjc merged commit e68b5eb into master Mar 21, 2018
@drmjc drmjc deleted the additional-gbs-filters branch March 21, 2018 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmjc drmjc drmjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VelNZ @drmjc