Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add ability to switch render modes under Qt 6 #917

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Re-add ability to switch render modes under Qt 6 #917

wants to merge 4 commits into from

Commits on May 3, 2024

  1. Re-add ability to switch render modes under Qt 6 

    Fixes #880, where QSG_VISUALIZE overdraw, and other modes, were
not working under Plasma.  Note, other render modes, such as
Vulkan, are yet to be implemented.
    @Cuperino
    Cuperino committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b942588 View commit details
    Browse the repository at this point in the history

  2. Shrink unsuported renderer overlay so test can access valid image data 

    quickinspectortext was failing on windows because the overlay that
states "DirectX is not supported yet, please use OpenGL or Software
backend" dims color values, making color compare fail. A solution
for this is to make this overlay a little smaller, so we can get a
glimpse of the original colors from the corners we pick colors from
in this test.
    @Cuperino
    Cuperino committed May 3, 2024
    Configuration menu
    Copy the full SHA
    bd3928f View commit details
    Browse the repository at this point in the history

  3. Scale requestGrabWindow()'s image to fit size of window grab 

    grabbedFrame.image is sized according to display scaling, but
the contents of the image itself remain at their original,
non-scaled, resolution. There's a slim chance that the image is
scaled to fit the scaled canvas, and the quickinspectortest
passes. Most of the times, however, the image won't be scaled
to fit the canvas.

In this change we manually scale the image according to
devicePixelRatio to fit the image's canvas. This allows the test
to pass while keeping it unmodified.
    @Cuperino
    Cuperino committed May 3, 2024
    Configuration menu
    Copy the full SHA
    05e8566 View commit details
    Browse the repository at this point in the history

  4. Attempt to prevent CI crash when running quickinspectortest 

    QSGRendererInterface::Software appears to be the culprit, and
QSGRendererInterface::OpenVG wasn't supposed to be used, thus
they were both removed.
    @Cuperino
    Cuperino committed May 3, 2024
    Configuration menu
    Copy the full SHA
    17ad975 View commit details
    Browse the repository at this point in the history