Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spec compliance #193

Merged
merged 1 commit into from
Oct 30, 2019
Merged

fix spec compliance #193

merged 1 commit into from
Oct 30, 2019

Conversation

hsitter
Copy link
Contributor

@hsitter hsitter commented Oct 28, 2019

as per https://www.w3.org/Submission/ws-addressing/ the only well-known
uri in 2004/08 was anonymous and it has a role prefix. from the
implicit reading I can find on earlier versions the same applies to them.

so, when constructing the well-known URIs inject a role prefix when
dealing with specs up to 2004/08 and raise a warning when attempting to
use anything but anonymous

same for /id/unspecified

(recreates #180 which broke for reasons 馃槼)

as per https://www.w3.org/Submission/ws-addressing/ the only well-known
uri in 2004/08 was anonymous and it has a role prefix. from the
implicit reading I can find on earlier versions the same applies to them.

so, when constructing the well-known URIs inject a role prefix when
dealing with specs up to 2004/08 and raise a warning when attempting to
use anything but anonymous

same for /id/unspecified
@hsitter hsitter mentioned this pull request Oct 28, 2019
@dfaure-kdab dfaure-kdab merged commit 9cf8a4d into KDAB:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants