Add system information to summary tab

[nwrogers]

No description provided.

[milianw]

In you commit message, add a paragraph saying what this actually does. I.e.:

Show the following PerfFeature contents in a group box at the bottom of the summary page:

- foo
- bar
- asdf

Also, put the "Fixes: ..." on its own line at the very end

[milianw]

Looking at the result, I think it would be better to always show the system information, but make the overall summary page scrollable. I.e. remove the toggle switch, always show the contents, but if the window is not tall enough it will not be visible and the user has to scroll to see it.

[milianw]

please join with ", ", i.e. add a space after the comma

[milianw]

dito

[milianw]

also, looking at the output: could you please sort the sibling threads list before joining it? Currently, I get:

0,4,1,5,2,6,3,7

[milianw]

please use KFormat's formatByteSize, see heaptrack or https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html#ae7412420b70e2ca935d0ebed6770e313

[milianw]

I just realize that none of the labels on the summary page are selectable. Can you add that feature (afaik it's a property on the label), such that we can copy'n'paste from the summary page?

[milianw]

this is wrong, you need to pass in bytes, but totalMemoryInKiB, as the name indicates, is in KiB. So you'll have to multiply it by 1024.

[milianw]

FYI this could be simplified, but see above

siblingThreads += thread.split(',');

[milianw]

Looking at the output from perf again, I think I misunderstood this and only realize it now that I see how you parse this here. So, sorry, but this needs to be revised again:

the sibling threads seems to indicate hardware threads, i.e. CPU ids, that share the same core. So for my Intel 8 core e.g. I have:

• siblingCores=(0-7)
• siblingThreads=(0,4, 1,5, 2,6, 3,7)

this means, I have one CPU node with 8 cores on them, but actually two of them always share the same hardware (hyperthreading). So I have only 4 "real" cores, and 8 "virtual" ones.

So splitting and sorting like I proposed is very wrong. Sorry again. Instead, I'd suggest we change the format to something like this:

Sibling Cores: [0-7]
Sibling Threads: [0,4], [1,5], [2,6], [3,7]

So for both of these lists, wrap every entry in '[' and ']', then join everything together with commas.

[milianw]

this is still wrong, and actually worse than before ;-)

we want MetricBinaryDialect, but we need to convert totalMemoryInKib to bytes by adding a * 1024 here

[milianw]

use QLatin1String instead of QLatin1Literal please, the latter is Qt 4 stuff afaik

[milianw]

Also, the commit message is still not good, see comment up top

[milianw]

this and the following line needs to be reformatted to not be so long. I think something like this would be good, and it would also simplify the code a bit (note how you insert ", " and then replace it again later). Or am I missing something?

    auto formatCpuList = [](const QByteArrayList& list) -> QString {
        return QString::fromUtf8('[' + list.join("], [") + ']');
    };
    summaryResult.cpuSiblingCores = formatCpuList(features.siblingCores);
    summaryResult.cpuSiblingThreads = formatCpuList(features.siblingThreads);

[milianw]

excellent, that looks good. only needs to be rebased against current master now that I merged your other change to bring in the cost delegate

[nwrogers]

OK, done

[milianw]

excellent, thank you!