Add data to summary tab

[nwrogers]

No description provided.

[milianw]

this is not needed, the top 'N' entries uses the same data, and thus the same model, as the bottomUpCostModel. only a proxy is missing (cf. topproxy in heaptrack)

[milianw]

move this out of the MainWindow class context into an anonymous namespace above the first method implementation in this file. Then first construct temporaries for the integral values and only construct the strings later on as needed

namespace {
QString formatTimeString(quint64 nanoseconds)
{
    quint64 totalSeconds = nanoseconds / 1000000000;
    quint64 days = ...;
    quint64 hours = ...;
 
    auto format = [] (quint64 fragment, int precision = 2) -> QString {
        return QString::number(fragment).rightJustified(precision, '0');
    };
    auto optional = [format] (quint64 fragment) -> QString {
        return fragment > 0 ? format(fragment) + QLatin1Char(":") : QString();
    };
    return optional(days) + optional(hours) + optional(minutes) + format(seconds) + QLatin1Char('.') + format(milliseconds, 3);
}
}

[milianw]

for future code: prefer the STL, i.e. std::sort

[milianw]

remove, sorting should be handled by a proxy model

[milianw]

shouldn't be needed

[milianw]

missing initialization, I'd set both to = 0;

[milianw]

these two should be QSet

[milianw]

once these are sets, simply do uniqueThreads.insert(sample.tid) - it will either insert when not exist, or error out. Doing a contains check first then inserting is going to be just as slow/fast, except when we actually insert - then we do the contains check twice.

[milianw]

dito

[milianw]

prefer the generic size method, which also exists in STL containers

[milianw]

two small changes, then it looks good to me.

on a conceptual level, please in the future split such changes up:

• first patch would add the summary data
• second patch would add the top proxy

if you want, you could do that now and learn how to do it with git, otherwise I'm fine with just the amend and push it as one patch. I'm more mentioning it here now so that you get a feeling of where I'd draw the line between commits

good work!

[milianw]

add a newline in here somewhere (in the code) to break this long line, i.e. something like

    return optional(days) + optional(hours) + optional(minutes)
           + format(seconds) + QLatin1Char('.') + format(milliseconds, 3);

[milianw]

it will return at most 5, no? so this has to be something like:

if (parent.isValid()) {
    return 0; // this is a flat list, not a tree
}
return std::min(5, sourceModel()->rowCount(parent));