feat: allow handling of compressed perfparser files #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milianw
requested changes
Jul 10, 2024
|
ping @milianw for answering the review comments, enabling me to push an updated version for merge |
GitMensch
force-pushed
the
gzperfparser
branch
from
ac41f34
to
f5b99aa
Compare
|
rebased + changed the lamda + added a check for "no magic header in compressed file" |
GitMensch
force-pushed
the
gzperfparser
branch
from
f5b99aa
to
d9d5cec
Compare
all of the code was in place but checking for perfparser format used the original filename instead the temporary (unpacked) one
GitMensch
force-pushed
the
gzperfparser
branch
from
d9d5cec
to
e6ce4c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all of the code was in place but checking for perfparser format used the original filename instead the temporary (unpacked) one
I guess that xz format is always available when KFArchive_FOUND is set - but if this isn't the case I'll change the test from xz to gz.
note: I'm open to suggestions for accessing the filename different than via
m_parserArgs[1]...