Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERROR: evaluation result not accounted for: 'silva_conflict' #37

Closed
chassenr opened this issue Sep 7, 2022 · 4 comments
Closed

ERROR: evaluation result not accounted for: 'silva_conflict' #37

chassenr opened this issue Sep 7, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@chassenr
Copy link

chassenr commented Sep 7, 2022

Hi,

I am testing MDMcleaner (version 0.8.3 installed via conda) on a set of bins, and I receive the following error:

-->evaluating contigs and setting filter-flags
         finished 60%. Currently analysing apparent reference database ambiguity
THERE WAS A EXCEPTION WHILE HANDLING ../bins_IOWseq000005_pre_anvio/Co_bin.92.orig.fa


ERROR: evaluation result not accounted for: 'silva_conflict'

Traceback (most recent call last):
  File "/bio/Software/anaconda3/envs/mdmcleaner-0.8.3/lib/python3.10/site-packages/mdmcleaner/clean.py", line 197, in main
    db_suspects = bindata.evaluate_and_flag_all_contigs(db=db, protblasts=protblasts, nucblasts=nucblasts, db_suspects=db_suspects, fast_run=args.fast_run)
  File "/bio/Software/anaconda3/envs/mdmcleaner-0.8.3/lib/python3.10/site-packages/mdmcleaner/getmarkers.py", line 1194, in evaluate_and_flag_all_contigs
    is_potential_refdb_contam = step2()
  File "/bio/Software/anaconda3/envs/mdmcleaner-0.8.3/lib/python3.10/site-packages/mdmcleaner/getmarkers.py", line 1164, in step2
    if db_suspects.last_checked_evaluations() == "OK":
  File "/bio/Software/anaconda3/envs/mdmcleaner-0.8.3/lib/python3.10/site-packages/mdmcleaner/review_refdbcontams.py", line 271, in last_checked_evaluations
    assert le == "OK", "\nERROR: evaluation result not accounted for: '{}'\n".format(le)
AssertionError:
ERROR: evaluation result not accounted for: 'silva_conflict'

In total, I had 144 bins and this error was thrown for 2 of them. Do you have any suggestions of how to solve this error?

Thanks!

Cheers,
Christiane

@jvollme
Copy link
Collaborator

jvollme commented Sep 7, 2022

hi, i will try to look into it. would you mind sending me the fastas of the bins that produced errors? ( I can provide an upload link for that soon, as soon as a current problem on our fileserver has been solved).

@jvollme
Copy link
Collaborator

jvollme commented Sep 7, 2022

in this particular case, there is a bug in the current mdmcleaner version that raises an error during resolution of reference-database-ambiguities if GTDB and silva taxonomies for the same reference marker gene directly contradict each other (intended default behaviour should be to simply prefer gtdb over silva in such cases). I will try to fix it as soon as possible. as a temporary workaround you could run mdmcleader clean with the --fast_run argument (for these bins only).

but considering your other problem it would really be helpful to have the fastas of the problematic bins.
also could you perhaps also send me the new_blacklist_additions.tsv and overview_refdb_ambiguities.tsv files produced during your original run?

@jvollme jvollme self-assigned this Sep 7, 2022
@jvollme jvollme added the bug Something isn't working label Sep 7, 2022
@chassenr
Copy link
Author

chassenr commented Sep 9, 2022

Just FYI, I sent you the specified files via email.

@chassenr
Copy link
Author

chassenr commented May 8, 2023

I am closing this issue because the error did not persist in the latest version of mdmcleaner. Thanks a lot for looking into this and sorry for my very delayed response.

@chassenr chassenr closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants