New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #704 (DXF reader: rational splines not supported) #705
Conversation
…cy is still maintained.
Interesting! Are Splines accessible as a primitive object in python?
Lukas Chrostowski
Professor, Electrical and Computer Engineering
University of British Columbia
Quantum Matter Institute
Member, College of the Royal Society of Canada
http://www.mina.ubc.ca/lukasc
http://siepic.ubc.ca
https://qmi.ubc.ca/about/directory/lukas-chrostowski
… On Jan 20, 2021, at 2:17 PM, Matthias Köfferlein ***@***.***> wrote:
You can view, comment on, or merge this pull request online at:
#705
Commit Summary
Fixed issue #704. TODO: replace algorithm by De Boor, check if accuracy is still maintained.
Switch spline interpolation algorithm to De Boor for better numerical stability.
Updated tests with DXF accuracy test, provide a warning for unsupported SPLINE types.
File Changes
M src/plugins/streamers/dxf/db_plugin/dbDXFReader.cc (208)
M src/plugins/streamers/dxf/db_plugin/dbDXFReader.h (2)
M src/plugins/streamers/dxf/unit_tests/dbDXFReaderTests.cc (28)
Patch Links:
https://github.com/KLayout/klayout/pull/705.patch
https://github.com/KLayout/klayout/pull/705.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@lukasc-ubc Excellent idea! And done (awaits merge): #706 :) |
* Fixed issue #704. TODO: replace algorithm by De Boor, check if accuracy is still maintained. * Switch spline interpolation algorithm to De Boor for better numerical stability. * Updated tests with DXF accuracy test, provide a warning for unsupported SPLINE types.
Please create a new issue. This one isn't an issue, but a pull request and it is closed. BTW: rational splines are supported. The problem is the order of records that ezdxf produces. The test file I got for developing that feature has a record sequence of
while ezdxf produces:
KLayout does not digest this order properly. When I manually change it, the circle looks at it is supposed to. Matthias |
Never mind. I created an issue for this: #1173 |
No description provided.