Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating a debug message for every successfully instantiated key is excessively noisy and generally not helpfull. Similarly, indicating a failure to look up the hold-tap key when failure is the expected outcome, is not usefull information and has confused users in the past. (The HT check is not pretty, but necessary in order to bind
KC.HT
toHoldTap
instead of modules inheriting the constructor, fyi)This PR addresses both of those inconveniences.