Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let copy-compiled remove old mpy files from device #987

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

xs5871
Copy link
Collaborator

@xs5871 xs5871 commented Jun 12, 2024

No description provided.

@claycooper
Copy link
Member

Are people going to want to selectively copy compiled files? Or does our stance of not mixing and matching modules preclude that?

@xs5871
Copy link
Collaborator Author

xs5871 commented Jun 20, 2024

At least boards based on the nice!nano want to strip out unused modules and that is what we have been recommending in the past to get around limited flash. But those wouldn't use the bulk copy with copy-compiled target anyway.
Occasionally we remove or rename files. I would consider not cleaning up old "binaries" during an update process a bug, that's the rational.

@claycooper
Copy link
Member

I agree with that stance.

@xs5871 xs5871 merged commit b49b728 into main Jun 20, 2024
2 checks passed
@xs5871 xs5871 deleted the enhancement-makefile branch June 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants