Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manaan Hrakert Rift - Star Map does not close #734

Closed
WildKarrde1138 opened this issue Dec 3, 2023 · 3 comments
Closed

Manaan Hrakert Rift - Star Map does not close #734

WildKarrde1138 opened this issue Dec 3, 2023 · 3 comments
Labels
Low Priority Bottom of the pile Module: Manaan Issue occurs primarily on Manaan Type: Scripting This issue is related specifically to a scripting bug/error

Comments

@WildKarrde1138
Copy link

Unlike the star maps on Tatooine, Kashyyyk, and Korriban, the one on Manaan does not seem to close after showing the player the map. From examining the scripts, it looks like Manaan is the only one of the four that does not use the utility function UT_StarMap4RunStarMap, which (among other things) queues the open, map, and close animations in sequence. The Manaan map queues the open and map animations in k_pman_starmap05.ncs but apparently never queues the close animation. Attached is a proposed fix which adjusts the code to match UT_StarMap2PlayAnimation (leaving out the SW_PLOT_HAS_TALKED_TO check, which wasn’t in the original k_pman_starmap05).
Manaan Star Map Close Fix - Proposed.zip

It's also worth noting that the Dantooine star map doesn’t appear to close either, which I presume was intentional so that it stays open through the conversation that follows. Not sure if it would be worth adding a command somewhere to close it after the conversation ends or if it’s better to leave as-is.

@DarthParametric DarthParametric changed the title Manaan Star Map Does Not Close Manaan Hrakert Rift - Star Map does not close Dec 3, 2023
@DarthParametric DarthParametric added Low Priority Bottom of the pile Module: Manaan Issue occurs primarily on Manaan Type: Scripting This issue is related specifically to a scripting bug/error labels Dec 4, 2023
@DarthParametric
Copy link
Contributor

DarthParametric commented Dec 13, 2023

The changes made as part of #756 can be utilised to address this.

See also #105 for previous edits made to the Dantooine map sequence that can incorporate the same changes if needed.

@DarthParametric
Copy link
Contributor

DarthParametric commented Dec 13, 2023

Couple of other issues I spotted.

  • The star map is sitting a few inches off the ground. Edit: This is due to the walkmesh not aligning with the terrain mesh. Don't want to edit the room model just for that. Adjusting the camera hides it anyway.
  • The second shot of the open map, static cam 6, is from a low angle, which shows the hole in the top of the skybox.

@DarthParametric
Copy link
Contributor

DarthParametric commented Dec 18, 2023

1.10.0 beta test 2 observations:

  • The additional static cam shots should be added to all map stages, not just the final one. Looking at it again, it's fine as-is. The additional angles aren't particularly useful to the early anims.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority Bottom of the pile Module: Manaan Issue occurs primarily on Manaan Type: Scripting This issue is related specifically to a scripting bug/error
Projects
None yet
Development

No branches or pull requests

2 participants