Make Prev_target Vector2d #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thebhatman wont it create any bug on first call? |
|
It doesn't create an error because I have also changed prev_target to be of Vector2D() instead of None. But because of that prev_target will be (0,0) in the very first call. This might cause one unnecessary replan in the beginning. I can change the initialisation of prev_target. |
|
But what if the target is in the vicinity of (0,0), then it will not replan. That can be a problem in the initialisation of velocity instance. |
|
Closing this because of this change #62. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prev_target was never really vector2D and checking isinstance was creating a problem. So this patch fixes it.