Merge #4025 Recommendations usability improvements

CHANGELOG.md

@@ -9,6 +9,7 @@ All notable changes to this project will be documented in this file.
 - [Updater] Support dev builds for auto updater (#3997, #4008 by: HebaruSan)
 - [GUI] Sort mods satisfying the same recommendation by download count (#4007 by: HebaruSan)
 - [Multiple] Alternate game command lines and Steam refactor (#4010, #4013 by: HebaruSan)
+- [Multiple] Recommendations usability improvements (#4025 by: HebaruSan)
 
 ### Bugfixes
 

Core/ModuleInstaller.cs

@@ -1343,12 +1343,21 @@ private void DownloadModules(IEnumerable<CkanModule> mods, IDownloader downloade
                                                     registry, crit);
             var recommenders = resolver.Dependencies().ToHashSet();
 
+            var checkedRecs = resolver.Recommendations(recommenders)
+                                      .Where(m => resolver.ReasonsFor(m)
+                                                          .Any(r => (r as SelectionReason.Recommended)?.ProvidesIndex == 0))
+                                      .ToHashSet();
+            var conflicting = new RelationshipResolver(toInstall.Concat(checkedRecs), null,
+                                                       RelationshipResolverOptions.ConflictsOpts(),
+                                                       registry, crit)
+                                  .ConflictList.Keys;
+            // Don't check recommendations that conflict with installed or installing mods
+            checkedRecs.ExceptWith(conflicting);
+
             recommendations = resolver.Recommendations(recommenders)
                                       .ToDictionary(m => m,
                                                     m => new Tuple<bool, List<string>>(
-                                                             resolver.ReasonsFor(m)
-                                                                     .Any(r => (r as SelectionReason.Recommended)
-                                                                                   ?.ProvidesIndex == 0),
+                                                             checkedRecs.Contains(m),
                                                              resolver.ReasonsFor(m)
                                                                      .Where(r => r is SelectionReason.Recommended rec
                                                                                  && recommenders.Contains(rec.Parent))

Core/Relationships/RelationshipResolver.cs

@@ -737,6 +737,15 @@ public static RelationshipResolverOptions KitchenSinkOpts()
                 get_recommenders               = true,
             };
 
+        public static RelationshipResolverOptions ConflictsOpts()
+            => new RelationshipResolverOptions()
+            {
+                without_toomanyprovides_kraken = true,
+                proceed_with_inconsistencies   = true,
+                without_enforce_consistency    = true,
+                with_recommends                = false,
+            };
+
         /// <summary>
         /// If true, add recommended mods, and their recommendations.
         /// </summary>