Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckan.dll: find a *folder* and install it #376

Closed
pjf opened this issue Nov 15, 2014 · 6 comments · Fixed by #681
Closed

ckan.dll: find a *folder* and install it #376

pjf opened this issue Nov 15, 2014 · 6 comments · Fixed by #681
Assignees
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement Netkan Issues affecting the netkan data Spec Issues affecting the spec
Milestone

Comments

@pjf
Copy link
Member

pjf commented Nov 15, 2014

It's common to see mod which start with Foo-1.2.3/GameData/Foo/ style paths, particularly when built from github releases.

I'd love to have something just like our default install stanza, but allowing us to target a different folder name than the one in the identifier.

Given that we already have code to do this, it should be relatively easy. But we need a name for the spec.

{
    "find" : "MyMod",
    "install_to" : "GameData"
}

Where find is exclusive to file. This means that our default stanza is the equivalent of:

{
   "find" : { "$ref" : "/identifier" },
   "install_to" : "GameData"
}

This would require we bump the spec number.
@pjf
Copy link
Member Author

pjf commented Dec 10, 2014

Bumping this to v1.4. It's a new feature, and my goodness I want to get v1.2 out. After v1.2 new spec changes will be much easier, as we'll be splitting the repo.

@pjf pjf modified the milestones: v1.4.0, v1.2.0 Dec 10, 2014
@TriggerAu
Copy link

Can this please be looked at sooner rather than later - CKAN is causing a split in the installations of my mods and making support a challenge. I love this, but its causing me some pain.

@pjf
Copy link
Member Author

pjf commented Dec 24, 2014

My plan is to work on this today, rather than pop into IRC. :)

@TriggerAu
Copy link

ooh, exciting. thanks

@pjf
Copy link
Member Author

pjf commented Dec 24, 2014

@TriggerAu: You are amazing and everyone loves you and your mods. I'm very committed to getting this out... not least because I want to install more TriggerAu mods. :)

pjf added a commit to pjf/CKAN that referenced this issue Dec 24, 2014
pjf added a commit to pjf/CKAN that referenced this issue Dec 24, 2014
- `ModuleInstallDescriptor.DefaultInstallStanza` replaces the old one
  in ModuleInstaller.
- `ModuleInstallDescriptor` serialisation options are much more
  explicit.
- `ConvertFindToFile` allows generation of a `file` stanza from a `find`
  stanza and zipfile. (This is our old DefaultInstallStanza repurposed.)
- Tests updated.
- For KSP-CKAN#376
pjf added a commit to pjf/CKAN that referenced this issue Dec 24, 2014
@pjf
Copy link
Member Author

pjf commented Dec 24, 2014

I have a build which works with this:

"install" :[
    {
        "find"       : "TriggerTech",
        "install_to" : "GameData",
        "filter"     : "Flags"
    }
]

And also this:

"install" : [
    {
        "find"       : "KSPAlternateResourcePanel",
        "install_to" : "GameData/TriggerTech",
    }
]

Which I think is pretty promising. :)

(Branch is at https://github.com/pjf/CKAN/tree/376_folder_install if you wish to follow along.)

pjf added a commit to pjf/CKAN that referenced this issue Dec 24, 2014
More of these would be better... but hey, tests! :)

For KSP-CKAN#376.
@pjf pjf self-assigned this Dec 24, 2014
@pjf pjf removed the Pull request label Dec 24, 2014
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
- `ModuleInstallDescriptor.DefaultInstallStanza` replaces the old one
  in ModuleInstaller.
- `ModuleInstallDescriptor` serialisation options are much more
  explicit.
- `ConvertFindToFile` allows generation of a `file` stanza from a `find`
  stanza and zipfile. (This is our old DefaultInstallStanza repurposed.)
- Tests updated.
- For KSP-CKAN#376
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement Netkan Issues affecting the netkan data Spec Issues affecting the spec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants