Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: Indicate when an upgrade will be save-breaking. #60

Open
pjf opened this issue Oct 13, 2014 · 6 comments
Open

Spec: Indicate when an upgrade will be save-breaking. #60

pjf opened this issue Oct 13, 2014 · 6 comments
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement Spec Issues affecting the spec ★★☆

Comments

@pjf
Copy link
Member

pjf commented Oct 13, 2014

Some mods are save-breaking, and can't be upgraded automatically (RSS 8 is an example). Since ckan update; ckan upgrade is likely to be common, we don't want to surprise users by breaking their saves.

We need a way to indicate in the CKAN file when a mod is not safe to upgrade.

@pjf pjf added this to the Advanced Features. milestone Oct 13, 2014
@NathanKell
Copy link
Contributor

I think you mean RF v8 :)

@pjf
Copy link
Member Author

pjf commented Oct 14, 2014

I think you mean RF v8 :)

This is a beautiful example of why I need the CKAN; I would have totally gone and broken all my saves, and still not upgraded RSS, because RF hashed to RSS in my dodgy human memory. ;)

@pjf
Copy link
Member Author

pjf commented Oct 14, 2014

My thoughts regarding this are:

  • Modules can't predict which releases in the future will break them.
  • Modules can predict which releases form the past they will break.

Therefore something with the semantics of breaks < 8.0 indicates that an upgrade is not safe if a version of the mod less than 8.0 is already installed, whereas upgrading from 8.0 to 8.3 would be just fine.

@NathanKell
Copy link
Contributor

That makes sense to me; by definition save-breaking is going to be a backwards-looking attribute.

@AlexanderDzhoganov
Copy link
Member

In addition to that, I think we should do our best to discourage save-breaking mods by displaying a big nasty can't-ignore-this warning message to the user on upgrade.

@pjf
Copy link
Member Author

pjf commented Oct 18, 2014

In addition to that, I think we should do our best to discourage save-breaking mods by displaying a big nasty can't-ignore-this warning message to the user on upgrade.

Yes. Yes so much.

@pjf pjf added ★★☆ Policy Issues with our policy Spec Issues affecting the spec Core (ckan.dll) Issues affecting the core part of CKAN and removed help wanted labels Oct 21, 2014
@pjf pjf modified the milestone: Advanced Features. Oct 27, 2014
@pjf pjf removed the Policy Issues with our policy label Dec 4, 2014
@pjf pjf changed the title Save-breaking upgrades? Spec: Indicate when an upgrade will be save-breaking. Dec 4, 2014
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
…w_pos

Remember window position + size on close
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement Spec Issues affecting the spec ★★☆
Projects
None yet
Development

No branches or pull requests

3 participants