Adjust spec version requirements to match usage. #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the spec has always had strict requirements as to what characters are allowed in versions, this has not been reflected by our software. Indeed, we're not really able to restrict how authors version their releases, the best we can do is hope they're sane, or bump the epoch if they're not. This change alters the spec to weaken the requirement on spec numbers to be a recommendation, reflecting how we actually handle things. This *is* changing the spec as written, but it's matching reality, so we're not changing what users see. Even so, discussion is welcome (even after this is merged). Closes KSP-CKAN#1174. Not as cool as KSP-CKAN#834. [Our policy on versions](https://github.com/KSP-CKAN/CKAN/blob/master/policy/version-comparison.md) should be kept in mind in discussions.
RichardLake
added a commit
that referenced
this pull request
Jun 29, 2015
Adjust spec version requirements to match usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the spec has always had strict requirements as to what characters
are allowed in versions, this has not been reflected by our software.
Indeed, we're not really able to restrict how authors version their
releases, the best we can do is hope they're sane, or bump the epoch
if they're not.
This change alters the spec to weaken the requirement on spec numbers
to be a recommendation, reflecting how we actually handle things.
This is changing the spec as written, but it's matching reality, so
we're not changing what users see. Even so, discussion is welcome (even
after this is merged).
Closes #1174.
Not as cool as #834.
Our policy on versions should be kept in mind in discussions.