Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client is now movable during the refresh #1198

Merged
merged 1 commit into from Jul 15, 2015
Merged

Client is now movable during the refresh #1198

merged 1 commit into from Jul 15, 2015

Conversation

Postremus
Copy link
Contributor

solves one part of #839

@pjf
Copy link
Member

pjf commented Jun 27, 2015

You are awesome. :)

Tomorrow is sprint day for me, and I'm looking forward to merging all the things tomorrow (if I'm not beaten to it first, which is even better!).

@@ -366,6 +366,13 @@ protected override void OnLoad(EventArgs e)

protected override void OnFormClosing(FormClosingEventArgs e)
{
//Only close the window, when the user has access to the "Exit" of the menu
if (!menuStrip1.Enabled)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking the logic here: if the menu strip isn't enabled, then closing the window is treated as a cancel instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the menustrip isn't enabled (e.g. the user isn't allowed to click on the menustrip), we disallow closing of the form.

@pjf
Copy link
Member

pjf commented Jul 15, 2015

Notes for me:

  • The client wasn't able to hit 'x' to close the form before this change, so it's not a user-visible change that they can now.
  • Testing by @plague006 confirms this works as intended under Windows.
  • Testing by me confirms this doesn't change behaviour under Linux (which always allows moving windows).

Merging with thanks. :)

@pjf pjf merged commit 431d9bf into KSP-CKAN:master Jul 15, 2015
@pjf pjf removed the Pull request label Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants