Performance Enhancements #1229
Merged
Performance Enhancements #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postremus
changed the title
|
puu.sh seems to be having troubles right now, and I'd love to see the performance graphs! :) |
|
Sorry for them not being available. uploaded them to github. |
| @@ -72,7 +72,6 @@ private void UpdateRepo(object sender, DoWorkEventArgs e) | |||
| private void PostUpdateRepo(object sender, RunWorkerCompletedEventArgs e) | |||
| { | |||
| SetDescription("Scanning for manually installed mods"); | |||
There was a problem hiding this comment.
Shouldn't this line also be removed?
There was a problem hiding this comment.
ah, I see the reason :)
We only need to know if any mod provides the specified mod, not which mods provides it.
this improves the launch time a bit
the call is already done before the refresh, and we don't need to do it twice
this removes unneeded calls to Availablemodule.Latest(..)
|
rebased the pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling was started before clicking on Refresh, and stopped after.
Before my changes:
After my changes:
