Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation into subdirectories of Ships #1243

Merged
merged 3 commits into from Jul 30, 2015

Conversation

dbent
Copy link
Member

@dbent dbent commented Jul 5, 2015

Fixes #1134, allowing install_to directives to specify Ships/VAB or Ships/SPH to install into those subdirectories. We still don't allow mods to create directories within Ships though.

Still needs:

  • Tests
  • Documentation Update

This would require a bump to the spec_version to v1.12.

@dbent
Copy link
Member Author

dbent commented Jul 5, 2015

Tests done. Documentation done in #1244.

This isn't as useful as I thought, because I forgot we can't actually rename files/folders. So you either have to specify all the files explicitly or the package has to have the right Ships/(VAH|SPH) structure. It would be nice to have an install_as clause so you could do something like:

{
    "spec_version": "v1.x",
    "identifier": "AwesomeMod",
    "install": [
        {
            "file": "ExampleShips",
            "install_as": "Ships/VAB"
        }
    ]
}

Then all the contents of ExampleShips would be dumped into Ships/VAB.

@dbent dbent changed the title [WIP] Allow installation into subdirectories of Ships Allow installation into subdirectories of Ships Jul 5, 2015
@pjf
Copy link
Member

pjf commented Jul 16, 2015

Given how often users manage to delete their SPH/VAB/@thumbs directories, we should re-create those if required. (Not a requirement for this PR, but noting it down because it just came up on IRC...)

@pjf
Copy link
Member

pjf commented Jul 30, 2015

Are the files in @thumbs auto-generated by KSP? Right now I presume we allow installation to it (because it exists, and we'll copy things from Ships), so it would make sense to allow it to be specified as an install target as well.

@pjf
Copy link
Member

pjf commented Jul 30, 2015

Aha, @thumbs is auto-generated by KSP (thanks @Postremus). This is on my review queue. :)

@pjf
Copy link
Member

pjf commented Jul 30, 2015

Tested on KSP-CKAN/NetKAN#1837 , and seems to be working fine. Merge in progress. :)

@pjf pjf merged commit 38fc2b8 into master Jul 30, 2015
@pjf pjf removed the Pull request label Jul 30, 2015
pjf added a commit that referenced this pull request Jul 30, 2015
* origin/topic/install_ships_subdirectory:
  Something in CI is causing this to be checked, weird
  Add tests
  Allow installation into subdirectories of Ships
pjf added a commit that referenced this pull request Jul 30, 2015
* 1243_adjust:
  Indicate 1.12 would be new/highest spec
  Something in CI is causing this to be checked, weird
  Add tests
  Update to allowed folders for v1.12
  Allow installation into subdirectories of Ships
@pjf pjf deleted the topic/install_ships_subdirectory branch July 30, 2015 21:38
@pjf
Copy link
Member

pjf commented Jul 30, 2015

Merged with great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants