New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installation into subdirectories of Ships #1243
Conversation
Tests done. Documentation done in #1244. This isn't as useful as I thought, because I forgot we can't actually rename files/folders. So you either have to specify all the files explicitly or the package has to have the right Ships/(VAH|SPH) structure. It would be nice to have an {
"spec_version": "v1.x",
"identifier": "AwesomeMod",
"install": [
{
"file": "ExampleShips",
"install_as": "Ships/VAB"
}
]
} Then all the contents of |
Given how often users manage to delete their SPH/VAB/@thumbs directories, we should re-create those if required. (Not a requirement for this PR, but noting it down because it just came up on IRC...) |
Are the files in |
Aha, |
Tested on KSP-CKAN/NetKAN#1837 , and seems to be working fine. Merge in progress. :) |
* origin/topic/install_ships_subdirectory: Something in CI is causing this to be checked, weird Add tests Allow installation into subdirectories of Ships
Merged with great thanks! |
Fixes #1134, allowing
install_to
directives to specifyShips/VAB
orShips/SPH
to install into those subdirectories. We still don't allow mods to create directories withinShips
though.Still needs:
This would require a bump to the
spec_version
tov1.12
.